Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base classes are defined now in the spec #1278

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

iherman
Copy link
Member

@iherman iherman commented Sep 13, 2023

This is a PR against #1272

The vocabulary definitions for the base classes have been changed to rely on the table in the VCDM specification.

@brentzundel brentzundel merged commit 903d46d into msporny-base-classes Sep 14, 2023
2 checks passed
@iherman
Copy link
Member Author

iherman commented Sep 15, 2023

The issue was discussed in a meeting on 2023-09-14

  • no resolutions were taken
View the transcript

1.6. Add base classes and fragment identifiers for vocabulary. (pr vc-data-model#1272)

See github pull request vc-data-model#1272.

Brent Zundel: primarily editorial, raised a few days ago.

Manu Sporny: Yes to all of that, just need to merge TallTed's changes.

See github pull request vc-data-model#1278.

Ivan Herman: For the record, I did 1278 yesterday.
� it's on top of 1272.

Manu Sporny: agree to merge on top of it.

Brent Zundel: merged, back to 1272.
� still have 3 more days for reviews.
� manu to look at suggestions made, anticipating that the PR will be merged soon.

Sebastian Crane: What I was saying is that the ease of merging Ivan's PR illustrates how useful it is to push to a 'personal' branch �within� the W3C repository, not to your GitHub fork. It is not possible to push to someone else's GitHub fork, so that discussion would have involved lots of git commands if Manu hadn't pushed to the main repository.

@msporny msporny deleted the msporny-base-classes-vocab branch September 26, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants