Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base classes and fragment identifiers for vocabulary. #1272

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

msporny
Copy link
Member

@msporny msporny commented Sep 10, 2023

This PR attempts to address part of issue #1263 by defining base classes (and their anchors) in the VCDM specification.


💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Sep 26, 2023, 8:39 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL


😭  Sorry, there was an error generating the HTML. Please report this issue!
Specification: http://labs.w3.org/spec-generator/uploads/teRudZ/index.html?isPreview=true%3FisPreview%3Dtrue&publishDate=2023-09-26
ReSpec version: 34.1.8
File a bug: https://github.com/w3c/respec/
Error: undefined

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to, in the same PR, make the changes on the vocabulary.yml file, too? For each of those classes a defined_by statement should replace the comment field.... This would save us yet another PR/merge round.

(I can make a PR against this one if you prefer.)

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@iherman
Copy link
Member

iherman commented Sep 13, 2023

Would it be possible to, in the same PR, make the changes on the vocabulary.yml file, too? For each of those classes a defined_by statement should replace the comment field.... This would save us yet another PR/merge round.

(I can make a PR against this one if you prefer.)

Putting my money where my mouth is... I have created #1278 to do this.

@msporny, if you are o.k. with this, the best would be to merge #1278 right away into this one, so that all the possible comments would be at one place. I just did not want to directly edit your PR.

@iherman
Copy link
Member

iherman commented Sep 15, 2023

The issue was discussed in a meeting on 2023-09-14

  • no resolutions were taken
View the transcript

1.6. Add base classes and fragment identifiers for vocabulary. (pr vc-data-model#1272)

See github pull request vc-data-model#1272.

Brent Zundel: primarily editorial, raised a few days ago.

Manu Sporny: Yes to all of that, just need to merge TallTed's changes.

See github pull request vc-data-model#1278.

Ivan Herman: For the record, I did 1278 yesterday.
� it's on top of 1272.

Manu Sporny: agree to merge on top of it.

Brent Zundel: merged, back to 1272.
� still have 3 more days for reviews.
� manu to look at suggestions made, anticipating that the PR will be merged soon.

Sebastian Crane: What I was saying is that the ease of merging Ivan's PR illustrates how useful it is to push to a 'personal' branch �within� the W3C repository, not to your GitHub fork. It is not possible to push to someone else's GitHub fork, so that discussion would have involved lots of git commands if Manu hadn't pushed to the main repository.

@msporny
Copy link
Member Author

msporny commented Sep 26, 2023

Normative, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit e87076d into main Sep 26, 2023
2 checks passed
@msporny msporny deleted the msporny-base-classes branch September 26, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants