Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested updates #8

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
155 changes: 18 additions & 137 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ repository = "https://github.com/tweedegolf/lzjd-rs"
[dependencies]
clap = "3.2"
base64 = "0.13.1"
failure = "0.1.8"
failure_derive = "0.1.5"
murmurhash3 = { git = "https://github.com/malwaredb/murmurhash3-rs", branch = "update" }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will prevent publishing to crates.io.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, that's another abandoned crate.

I don't know what I was expecting with this PR. Maybe some acknowledgement from the maintainer. The abandoned crates thing bothers me.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hdoordt Maybe you can shed some light. Maybe you can transfer maintainership or get a grant for it?

bincode = "1.1.2"
crc = "1.8.1"
Expand Down
Loading