Suggested updates #8
Conversation
Signed-off-by: Richard Zak <[email protected]>
Signed-off-by: Richard Zak <[email protected]>
Signed-off-by: Richard Zak <[email protected]>
Signed-off-by: Richard Zak <[email protected]>
Signed-off-by: Richard Zak <[email protected]>
Signed-off-by: Richard Zak <[email protected]>
Signed-off-by: Richard Zak <[email protected]>
Signed-off-by: Richard Zak <[email protected]>
Cargo.toml
Outdated
| fasthash= "0.4.0" | ||
| clap = "3.2" | ||
| base64 = "0.13.1" | ||
| murmurhash3 = { git = "https://github.com/malwaredb/murmurhash3-rs", branch = "update" } |
There was a problem hiding this comment.
This will prevent publishing to crates.io.
There was a problem hiding this comment.
I know, that's another abandoned crate.
I don't know what I was expecting with this PR. Maybe some acknowledgement from the maintainer. The abandoned crates thing bothers me.
There was a problem hiding this comment.
@hdoordt Maybe you can shed some light. Maybe you can transfer maintainership or get a grant for it?
.github/workflows/commisery.yml
Outdated
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Run Commisery | ||
| uses: tomtom-international/commisery-action@v2 |
There was a problem hiding this comment.
Depnding on a hash might be better here, as the tag might change at any point.
.github/workflows/dco.yml
Outdated
| check: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: tisonkun/[email protected] |
|
I'm not affiliated with this repo, but TBH the two actions and Dependabot are pretty opinionated and I wouldn't have bundled them in the same PR. |
| }, | ||
| #[fail(display = "Error: {}", msg)] | ||
| Msg { msg: String }, | ||
| Io(String), |
There was a problem hiding this comment.
This drops the error information, which might not be ideal.
There was a problem hiding this comment.
I'm not sure of the best way to store the error information, I think just one string would be fine. I don't know that various enum types are helpful. But that crate had to be removed due to it also be abandoned and having security problems.
Signed-off-by: Richard Zak <[email protected]>
|
@rjzak Thanks for your work. I'm the new maintainer. Do you have a desire to further update the PR? |
|
I've decided to maintain and use my own fork, but I will address these comments. |
Signed-off-by: Richard Zak <[email protected]>
|
I addressed the CI actions with hash, and murmurhash dependency. Let me know if you want these commits to be squashed, or if there's something else. |
|
Afterwards, please don't squash since it's a mixture of unrelated changes. |
|
I take it that you noticed my review. |
fasthash, as it doesn't work on all platformsfailureas it's obsolete and deprecated.impl Displayinstead ofto_string().