Close connection when get gRPC error Code.Canceled #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ping Yu <[email protected]>
|
@bufferflies @iosmanthus @zeminzhou PTAL, thanks~ |
iosmanthus
approved these changes
Jan 17, 2024
bufferflies
approved these changes
Jan 17, 2024
zeminzhou
approved these changes
Jan 17, 2024
This was referenced Jan 19, 2024
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
Signed-off-by: Ping Yu <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
Signed-off-by: Ping Yu <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
Signed-off-by: Ping Yu <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
Signed-off-by: Ping Yu <[email protected]> Signed-off-by: zzm <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Mar 13, 2024
Signed-off-by: Ping Yu <[email protected]>
iosmanthus
pushed a commit
that referenced
this pull request
Mar 13, 2024
Co-authored-by: zzm <[email protected]> Co-authored-by: glorv <[email protected]> Co-authored-by: disksing <[email protected]> Co-authored-by: cfzjywxk <[email protected]> Co-authored-by: ShuNing <[email protected]> Co-authored-by: ekexium <[email protected]> Co-authored-by: Yongbo Jiang <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: Evan Zhou <[email protected]> Co-authored-by: iosmanthus <[email protected]> Co-authored-by: Ryan Leung <[email protected]> Co-authored-by: jinhelin <[email protected]> Co-authored-by: iosmanthus <[email protected]> Co-authored-by: Ping Yu <[email protected]> fix: check kill signal against 0 (#1102)" (#1129)" fix safepoint kv with keyspace name (#928) fix encoding of mvcc get by key (#775) close on canceled (#1121) Fix wait recvloop timeout (#1134) CloseAddr (#1140) Fix timeout of TestResolveTxnFallbackFromAsyncCommit (#1146)
pingyu
added a commit
to pingyu/client-go
that referenced
this pull request
Mar 13, 2024
Signed-off-by: Ping Yu <[email protected]>
pingyu
added a commit
that referenced
this pull request
Mar 14, 2024
* close on canceled (#1121) Signed-off-by: Ping Yu <[email protected]> * Fix wait recvloop timeout (#1134) * wip Signed-off-by: Ping Yu <[email protected]> * CloseAddr with ver Signed-off-by: Ping Yu <[email protected]> * fix ErrConn Signed-off-by: Ping Yu <[email protected]> * fix ut Signed-off-by: Ping Yu <[email protected]> * cleanup Signed-off-by: Ping Yu <[email protected]> --------- Signed-off-by: Ping Yu <[email protected]> * Use correct address for CloseAddr (#1140) * wip Signed-off-by: Ping Yu <[email protected]> * CloseAddr with ver Signed-off-by: Ping Yu <[email protected]> * fix ErrConn Signed-off-by: Ping Yu <[email protected]> * fix ut Signed-off-by: Ping Yu <[email protected]> * polish Signed-off-by: Ping Yu <[email protected]> * polish Signed-off-by: Ping Yu <[email protected]> * polish Signed-off-by: Ping Yu <[email protected]> --------- Signed-off-by: Ping Yu <[email protected]> * rebase Signed-off-by: Ping Yu <[email protected]> --------- Signed-off-by: Ping Yu <[email protected]> Co-authored-by: iosmanthus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1120
Close connection when get gRPC error as
Code.Canceled, as the error would be caused by keep alive timeout. Then the next retry will try to establish the connection again. Otherwise, as underlying gRPC client has been canceled, we will keep get the same error.