feat: support Aeva Aeries II

[mojomex]

PR Type

• New Feature

Description

Add support for Aeva Aeries II:

• output pointclouds with velocity info
• allow for frame sync, scan pattern and FoV setup via the launch config
• publish diagnostics (health + telemetry) to /diagnostics

Review Procedure

• Code review
• Test with sensor
  • Pointcloud fields are correct (use rviz2)
  • Packets are published when subscribed to when launch_hw:=true, subscribed to when launch_hw:=false
  • Diagnostics are correct (use rqt's Plugins->Robot Tools->Runtime Monitor)
• Test with PTP configs provided by Aeva

Remarks

This is a fairly minimal implementation for now.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[mojomex]

🟢 Evaluation

🟢 Pointcloud Output

Pointcloud Field	Image
azimuth
elevation
distance
range rate
intensity
channel
return type*
timestamp**

*: red: strongest, magenta: second strongest. Currently, there is no documented way to get or set the return mode without the proprietary API. Nebula is currently hard-coded for the default configuration. fixed in 7ea9137. Return modes are now correctly handled.
**: clamped to [red, magenta] = [0 ns, 1e8 ns]. Timestamps are loosely proportional to increasing elevation.

🟢 Performance

The pointcloud is published consistently at around 10 Hz:

🟢 Hardware Monitor

Diagnostic	Image
temperature
system info
SPC converter
scanner
health codes***
configuration

***: ⚠️ Currently, the descriptions of health codes are under NDA and cannot be put into Nebula.

🟢 PTP & Synchronization

PTP has been tested with all provided mechanisms (1588v2, gPTP, automotive) and works with all of them using the vendor-provided configurations.

Pointcloud timestamps take around 1-2 min to converge.

Description	Image
PTP started, sensor syncs shortly after
~100s later, timestamp converges to ToS
HW monitor shows converged state
HW monitor shows PTP info

🟢 Error Handling & Recovery

Currently, Nebula does not attempt to recover from communication errors and instead exits, instead of continuing in a possibly corrupted state.
Errors that have been observed:

• failing to connect to sensor early after power-on (sensor boots for ~1-2 mins)
• failing to fetch configuration manifest (timeout) fixed in 7781318 (protocol impl was wrong)
• receiving unexpected responses after configuration command fixed in 7781318 (protocol impl was wrong)

All of these errors only occur during startup. No crashes / errors were observed during runtime.

🟢 Parameters

All parameters from the sensor's manifest that have more than one possible value have been added to Nebula. No attempt was made to convert them to the common naming scheme used in the other drivers (e.g. return_mode for Aeva is second_peak_type).

Validation:

• Parameters are validated by the sensor and rejected by Nebula if the sensor reports them as invalid
• Parameters are automatically propagated to the hardware and decoder
• Parameter schema allows for auto-complete in config file

[mojomex]

@drwnz All issues from yesterday have been addressed and I could not find any bugs or unexpected behavior since. I think this is ready to merge.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0.57143% with 348 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@04c9a0b). Learn more about missing BASE report.

Files	Patch %	Lines
nebula_ros/src/aeva/aeva_ros_wrapper.cpp	0.00%	166 Missing ⚠️
nebula_ros/src/aeva/hw_monitor_wrapper.cpp	0.00%	77 Missing ⚠️
.../src/nebula_decoders_aeva/aeva_aeries2_decoder.cpp	0.00%	38 Missing ⚠️
...la_ros/include/nebula_ros/common/rclcpp_logger.hpp	0.00%	16 Missing ⚠️
nebula_tests/aeva/aeva_hw_interface_test.cpp	0.00%	13 Missing ⚠️
...a_ros/include/nebula_ros/aeva/aeva_ros_wrapper.hpp	0.00%	10 Missing ⚠️
...include/nebula_ros/common/nebula_packet_stream.hpp	0.00%	10 Missing ⚠️
nebula_tests/common/mock_byte_stream.hpp	0.00%	9 Missing ⚠️
...ros/include/nebula_ros/aeva/hw_monitor_wrapper.hpp	0.00%	3 Missing ⚠️
...ders/nebula_decoders_aeva/aeva_aeries2_decoder.hpp	0.00%	1 Missing ⚠️
... and 5 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop     #169   +/-   ##
==========================================
  Coverage           ?   14.61%           
==========================================
  Files              ?      103           
  Lines              ?     9207           
  Branches           ?     1540           
==========================================
  Hits               ?     1346           
  Misses             ?     6767           
  Partials           ?     1094           

Flag	Coverage Δ
differential	14.61% <0.57%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[knzo25]

description or default?