Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(system_error_monitor): remove system error monitor (#8929) #1551

Merged
merged 1 commit into from
Sep 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ system/mrm_comfortable_stop_operator/** [email protected] tomohito.ando@t
system/mrm_emergency_stop_operator/** [email protected] [email protected]
system/mrm_handler/** [email protected] [email protected] [email protected]
system/system_diagnostic_monitor/** [email protected]
system/system_error_monitor/** [email protected]
system/system_monitor/** [email protected] [email protected]
system/topic_state_monitor/** [email protected]
system/velodyne_monitor/** [email protected]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ void insertNewlines(std::string & str, const size_t max_line_length)

std::optional<std::string> generateMrmMessage(diagnostic_msgs::msg::DiagnosticStatus diag_status)
{
if (diag_status.hardware_id == "" || diag_status.hardware_id == "system_error_monitor") {
if (diag_status.hardware_id == "") {
return std::nullopt;
} else if (diag_status.level == diagnostic_msgs::msg::DiagnosticStatus::ERROR) {
std::string msg = "- ERROR: " + diag_status.name + " (" + diag_status.message + ")";
Expand Down
2 changes: 0 additions & 2 deletions launch/tier4_system_launch/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,3 @@ Note that you should provide parameter paths as `PACKAGE_param_path`. The list o
...
</include>
```

The sensing configuration parameters used in system_error_monitor are loaded from "config/diagnostic_aggregator/sensor_kit.param.yaml" in the "`SENSOR_MODEL`\_description" package.
4 changes: 0 additions & 4 deletions launch/tier4_system_launch/launch/system.launch.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@
<arg name="processing_time_checker_param_path"/>
<arg name="mrm_comfortable_stop_operator_param_path"/>
<arg name="mrm_emergency_stop_operator_param_path"/>
<arg name="system_error_monitor_param_path"/>
<arg name="system_error_monitor_planning_simulator_param_path"/>
<arg name="diagnostic_aggregator_system_param_path"/>
<arg name="diagnostic_aggregator_vehicle_param_path"/>
<arg name="dummy_diag_publisher_param_path"/>
<arg name="system_monitor_cpu_monitor_param_path"/>
<arg name="system_monitor_gpu_monitor_param_path"/>
Expand Down
1 change: 0 additions & 1 deletion launch/tier4_system_launch/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
<buildtool_depend>autoware_cmake</buildtool_depend>

<exec_depend>component_state_monitor</exec_depend>
<exec_depend>system_error_monitor</exec_depend>
<exec_depend>system_monitor</exec_depend>

<test_depend>ament_lint_auto</test_depend>
Expand Down
18 changes: 0 additions & 18 deletions system/system_error_monitor/CMakeLists.txt

This file was deleted.

145 changes: 0 additions & 145 deletions system/system_error_monitor/README.md

This file was deleted.

Empty file.

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading