beta/v0.3.18.2+aeb update #1528
Conversation
Signed-off-by: Daniel Sanchez <[email protected]>
Signed-off-by: Daniel Sanchez <[email protected]>
Signed-off-by: Daniel Sanchez <[email protected]>
Signed-off-by: Daniel Sanchez <[email protected]>
…autowarefoundation#8569) * make it so AEB works with only one req path type (imu or MPC) Signed-off-by: Daniel Sanchez <[email protected]> * fix missing mpc path return Signed-off-by: Daniel Sanchez <[email protected]> * add check Signed-off-by: Daniel Sanchez <[email protected]> * modify no path msg Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
…arefoundation#8611) fix bug by using the collision data keeper Signed-off-by: Daniel Sanchez <[email protected]>
|
|
|
||
| - Ego vehicle is not in autonomous driving state | ||
|
|
||
| - When the ego vehicle is not moving (Current Velocity is very low) |
There was a problem hiding this comment.
Current Velocity is very low
Regarding very low speed, please tell me the flow velocity threshold.
Also, where is it used in the source code?
There was a problem hiding this comment.
the flow velocity threshold.
Sorry what do you mean by the flow velocity threshold?
Also, where is it used in the source code?
checking in the following part
https://github.com/tier4/autoware.universe/pull/1528/files#diff-9e6b733808409255bcc5d8a574750015103ce298b94d7d54872ff348f6740d3eR418-R423
// step2. create velocity data check if the vehicle stops or not
constexpr double min_moving_velocity_th{0.1};
const double current_v = current_velocity_ptr_->longitudinal_velocity;
if (std::abs(current_v) < min_moving_velocity_th) {
return false;
}
|
|
||
|  | ||
|
|
||
| ## Parameters |
There was a problem hiding this comment.
Please also add the following parameters to the list.
- cluster_tolerance
- cluster_minimum_height
- minimum_cluster_size
- maximum_cluster_size
There was a problem hiding this comment.
@sfukuta apparently I cannot push new commits to this branch since I get this error:
remote: error: GH006: Protected branch update failed for refs/heads/beta/v0.3.18.2+AEB-update. remote: remote: - Changes must be made through a pull request. remote: remote: - 2 of 2 required status checks are expected. To https://github.com/tier4/autoware.universe.git ! [remote rejected] beta/v0.3.18.2+AEB-update -> beta/v0.3.18.2+AEB-update (protected branch hook declined) error: failed to push some refs to 'https://github.com/tier4/autoware.universe.git'
if your only concerns are about the README please approve this PR and I will make a separate PR to fix the README
Description
This PR updates the AEB module to be closer to current autoware's AEB and adds polling subscribers (AEB depends on them) to let the AEB module subscribe to its target topics.
Requires updates to launch: https://github.com/tier4/autoware_launch.x1.eve/pull/487
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.