-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests using explicitAttrs with value [ ]
#1605
Conversation
As discussed, this PR should be divided in 2 |
These tests are related with PR #1593 and described as
So not sure if a measure mapped to TimeInstnat attribute should not be propagated to CB in this case. |
As my understanding, TimeInstant should work as any other attribute, so, it should be filtered by explicitAttrs like any other attribute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding tests described in #1600
BUT some problems were discovered when using TimeInstant attribute and fucntionalities in cases 533 A) and B):
0533 B
0533 B