-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TimeInstant + explicitAttr tests (ftest 533) #1610
Conversation
This is a future regression case for issue #1606 |
resource: '/iot/json', | ||
apikey: globalEnv.apikey, | ||
entity_type: globalEnv.entity_type, | ||
explicitAttrs: "['DateIssued']", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mapedraza this explicitAttrs is not empty as suggest description case, is it?
TimeInstant: '2015-12-14T08:06:01.468Z' | ||
} | ||
}, | ||
expectation: {} // No payload expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mapedraza no CB update is represented in other testCases (like 0120) as null array:
expectation: []
IMHO with this group definition:
a TimeInstant will be always propaged to CB, regardless attribute mapping definition. This PR is as I think it would be: #1614 |
If the logic is that
by adding check that if (explicit instanceof Array && explicit.length > 0 && mustInsertTimeInstant) { |
overpassed by #1618 |
A part of original PR #1605 including test 533
See #1605 (comment)