Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme edit #78

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Readme edit #78

merged 5 commits into from
Aug 15, 2024

Conversation

martinzigrai
Copy link
Contributor

Readme update

Copy link
Member

@tompsota tompsota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job overall! Just a couple of comments below.

README.md Outdated

# About Us
For comprehensive and up-to-date guides, tutorials, and technical documentation, visit our [GitBook page](https://talsec.gitbook.io/freerasp). It serves as your go-to resource, offering everything from basic instructions to advanced tips and tricks to help you get the most out of our project.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reference Gitbook right at the beginning. Either just rephrase the sentence, or put a new sencence at the beginning (whole sentence as a link), then newline, then current content.

README.md Outdated

Talsec is an academic-based and community-driven mobile security company. We deliver in-App Protection and a User Safety suite for Fintechs. We aim to bridge the gaps between the user's perception of app safety and the strong security requirements of the financial industry.
:link: For integrating it on the React Native platform, be sure to follow all the steps in our [Integration Guide](https://talsec.gitbook.io/freerasp/integration). This guide provides detailed instructions to help you achieve a smooth and efficient integration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration is quite hidden there, I'd put it in a separate chapter before the Discover our GitBook Documentation part. Also please link directly react native integration. This is the most important thing in the readme, it should be emphasized more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the link to the general integration is a better option because there are steps that are also important. If I link them directly to the React Native integration, they won't do/read the steps on the general integration page. I discussed it with @msikyna.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allright, makes sense 👍

README.md Outdated

This project is provided as freemium software i.e. there is a fair usage policy that impose some limitations on the free usage. The SDK software consists of opensource and binary part which is property of Talsec. The opensource part is licensed under the MIT License - see the [LICENSE](https://github.com/talsec/Free-RASP-Community/blob/master/LICENSE) file for details.
# Reference to Our Legacy Documentation
If you encounter any discrepancies or errors in the documentation, please let us know so we can improve it and ensure the best experience for all users. For information on older integration methods, you can refer to the [freeRASP wiki](https://github.com/talsec/Free-RASP-ReactNative/wiki), which includes comprehensive legacy details and guidance. We appreciate your feedback, as it helps us refine our resources and better support your needs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old integration can be found when you checkout to specific tag (up to currently latest one) - I think this would be nice to mention.

please let us know so we can improve it and ensure the best experience for all users.

This feels to me like we know there are issues and want community to help fix it. Please rephrase it a bit, so it feels like we are more confident about our docs :D

..., as it helps us refine our resources and better support your needs.

This sentence feels a bit too simple, could you try to improve it?
example from chatgpt: Your input is invaluable in helping us improve our resources and provide even better support for your needs.

README.md Outdated

Talsec is an academic-based and community-driven mobile security company. We deliver in-App Protection and a User Safety suite for Fintechs. We aim to bridge the gaps between the user's perception of app safety and the strong security requirements of the financial industry.
:link: For integrating it on the React Native platform, be sure to follow all the steps in our [Integration Guide](https://talsec.gitbook.io/freerasp/integration). This guide provides detailed instructions to help you achieve a smooth and efficient integration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:link: For integrating it on the React Native platform, be sure to follow all the steps in our [Integration Guide](https://talsec.gitbook.io/freerasp/integration). This guide provides detailed instructions to help you achieve a smooth and efficient integration.
:link: For integrating freeRASP on the React Native platform, be sure to follow all the steps in our [Integration Guide](https://talsec.gitbook.io/freerasp/integration). This guide provides detailed instructions to help you achieve a smooth and efficient integration.

Just last minor change, then it will be great 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, noted. 😄

@martinzigrai martinzigrai merged commit 4289518 into talsec:master Aug 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants