Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: output json #183

Merged
merged 7 commits into from
Aug 21, 2024
Merged

feat: output json #183

merged 7 commits into from
Aug 21, 2024

Conversation

Aslemammad
Copy link
Member

@Aslemammad Aslemammad commented Aug 20, 2024

Resolves #173

Copy link

continuous-releases-staging bot commented Aug 20, 2024

commit: d674dcd

pnpm add https://d61368b4.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/playground-a@183
pnpm add https://d61368b4.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/playground-b@183
pnpm add https://d61368b4.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/pkg-pr-new@183

Open in Stackblitzexample-1example-2

@Aslemammad
Copy link
Member Author

@pngwn Can you try this in your workflow and see if --json works as expected for you?

        run: API_URL=https://pkg.pr.new pnpx pkg-pr-new@https://d61368b4.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/pkg-pr-new@183 publish './js/*' './client/js' --comment=off

You can just try different variations of --json on this command.

@pngwn
Copy link

pngwn commented Aug 20, 2024

I shall try!

@pngwn
Copy link

pngwn commented Aug 20, 2024

Works beautifully for stdout: https://github.com/gradio-app/gradio/actions/runs/10469032256/job/28991194562?pr=9153#step:5:150
And so does the JSON file option: https://github.com/gradio-app/gradio/actions/runs/10469152056/job/28991538458?pr=915

Thank youuuuuuuuu!

One question, it is also possible to install via link@pr number, would that still work?

@Aslemammad
Copy link
Member Author

Aslemammad commented Aug 20, 2024 via email

@pngwn
Copy link

pngwn commented Aug 20, 2024

That's great thanks!

Yep this looks perfect to merge from my end!

@Aslemammad
Copy link
Member Author

Aslemammad commented Aug 20, 2024 via email

@AmirSa12 AmirSa12 merged commit 6ba34b5 into main Aug 21, 2024
5 checks passed
@AmirSa12 AmirSa12 deleted the feat/json-output branch August 21, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON metadata export
3 participants