-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: output json #183
feat: output json #183
Conversation
commit:
|
@pngwn Can you try this in your workflow and see if --json works as expected for you? run: API_URL=https://pkg.pr.new pnpx pkg-pr-new@https://d61368b4.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/pkg-pr-new@183 publish './js/*' './client/js' --comment=off You can just try different variations of |
I shall try! |
Works beautifully for stdout: https://github.com/gradio-app/gradio/actions/runs/10469032256/job/28991194562?pr=9153#step:5:150 Thank youuuuuuuuu! One question, it is also possible to install via |
Thank you so much, yes it'd be possible but I did not put it in the
metadata because you can easily access the pr number from github
environment vars.
So you can construct the pr url easily for yourself.
Let me know if you have any questions, and if this can be merged ❤️
…On Tue, 20 Aug 2024, 13:16 pngwn, ***@***.***> wrote:
Works beautifully for stdout:
https://github.com/gradio-app/gradio/actions/runs/10469032256/job/28991194562?pr=9153#step:5:150
And so does the JSON file option:
https://github.com/gradio-app/gradio/actions/runs/10469152056/job/28991538458?pr=915
Thank youuuuuuuuu!
One question, it is also possible to install via ***@***.*** number, would
that still work?
—
Reply to this email directly, view it on GitHub
<#183 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJBMICG5QLEQJEHJ43J6AG3ZSMF75AVCNFSM6AAAAABMZGSOGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJYGQZTQMJSHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
That's great thanks! Yep this looks perfect to merge from my end! |
Thank you so much!
…On Tue, 20 Aug 2024, 15:53 pngwn, ***@***.***> wrote:
That's great thanks!
Yep this looks perfect to merge from my end!
—
Reply to this email directly, view it on GitHub
<#183 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJBMICEGWLMGFVDU6HVDMLLZSMYLZAVCNFSM6AAAAABMZGSOGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJYG4ZDQNBXHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Resolves #173