Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Stackblitz link #208

Closed
pomber opened this issue Aug 30, 2024 · 7 comments
Closed

Removing Stackblitz link #208

pomber opened this issue Aug 30, 2024 · 7 comments

Comments

@pomber
Copy link

pomber commented Aug 30, 2024

I was expecting the --no-template flag to remove the Open in Stackblitz link from the PR comment, but it isn't happening.

Is that how it works?

This is the full command I'm using:

pkg-pr-new publish --no-template --compact './packages/codehike'

And here is an example comment.

@Aslemammad
Copy link
Member

Hey, huge fan of your work on codehike, Rodrigo!

In the next version, this is solved!

Sorry for the confusion. I'll keep you updated here.

@pomber
Copy link
Author

pomber commented Aug 30, 2024

thanks! I added pkg.pr.new yesterday and it's already saving me much time.

Will there be a way to customize the comment? I'd love to change it to something like:

Install the version from this pull request in your project with: 

```
npm add https://pkg.pr.new/codehike@441
```

@Aslemammad
Copy link
Member

I appreciate that!

Yep, we just added #183, you can see the discussion there.

With that, you can create your own comments.

@Aslemammad
Copy link
Member

btw, if you think you need help with setting it up, I'd be happy to help!

@Aslemammad
Copy link
Member

I'll close this since I assume it is fixed with the new release. If in any case it was not, please feel free to re-open this.

@pomber
Copy link
Author

pomber commented Sep 7, 2024

thanks! I added pkg.pr.new yesterday and it's already saving me much time.

Will there be a way to customize the comment? I'd love to change it to something like:

Install the version from this pull request in your project with: 

```
npm add https://pkg.pr.new/codehike@441
```

@Aslemammad do you have any example of how to do this?

@Aslemammad
Copy link
Member

Aslemammad commented Sep 7, 2024

pnpm pkg-pr-new publish --json=output.json --comment=off

This would create you an output.json for you with all the built packages and templates.

Then you'd be able to create a script that comments to the current PR that uses output.json. In that script, you can format the messages however you want when sending the comment using github api!

https://github.com/octokit/action.js/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants