[action] [PR:14089] Make oscillation fix persistent across reboots and config reload #14486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic-net#14089) What is the motivation for this PR? sonic-net#13004, introduces a fix to disable oscillations at the session level for dualtor. The fix however is not persistent across reboots and config reload. During the sanity checks that run in the beginning of the tests, https://github.com/sonic-net/sonic-mgmt/blob/master/tests/conftest.py#L77, if it is found that any interfaces or BGP sessions is/are down (which could be due to a test that run before the current test and contaminated the testbed), a config_reload and then further a reboot is issued, which clears off this config to disable oscillation, resulting in a flakiness when the test runs or a sanity check failure again. How did you do it? The proposed fix is to do a config save -y of this config so as to make it persistent across reboots and config reload. How did you verify/test it? Ran the tests that were flaky due to oscillations. a) acl/test_acl.py b) drop_packets/drop_packets.py c) fib/test_fib.py Any platform specific information?
8 tasks
|
Original PR: #14089 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Make oscillation fix persistent across reboots.
Fixes #226
Type of change
Back port request
Approach
What is the motivation for this PR?
#13004, introduces a fix to disable oscillations at the session level for dualtor.
The fix however is not persistent across reboots and config reload.
During the sanity checks that run in the beginning of the tests, https://github.com/sonic-net/sonic-mgmt/blob/master/tests/conftest.py#L77, if it is found that any interfaces or BGP sessions is/are down (which could be due to a test that run before the current test and contaminated the testbed), a config_reload and then further a reboot is issued, which clears off this config to disable oscillation, resulting in a flakiness when the test runs or a sanity check failure again.
How did you do it?
The proposed fix is to do a config save -y of this config so as to make it persistent across reboots and config reload.
How did you verify/test it?
Ran the tests that were flaky due to oscillations.
a)
acl/test_acl.pyb)
drop_packets/drop_packets.pyc)
fib/test_fib.pyAny platform specific information?
Supported testbed topology if it's a new test case?
Documentation