Skip to content

Commit

Permalink
Make oscillation fix persistent across reboots and config reload (#14089
Browse files Browse the repository at this point in the history
)

What is the motivation for this PR?
#13004, introduces a fix to disable oscillations at the session level for dualtor.

The fix however is not persistent across reboots and config reload.

During the sanity checks that run in the beginning of the tests, https://github.com/sonic-net/sonic-mgmt/blob/master/tests/conftest.py#L77, if it is found that any interfaces or BGP sessions is/are down (which could be due to a test that run before the current test and contaminated the testbed), a config_reload and then further a reboot is issued, which clears off this config to disable oscillation, resulting in a flakiness when the test runs or a sanity check failure again.

How did you do it?
The proposed fix is to do a config save -y of this config so as to make it persistent across reboots and config reload.

How did you verify/test it?
Ran the tests that were flaky due to oscillations.
a) acl/test_acl.py
b) drop_packets/drop_packets.py
c) fib/test_fib.py

Any platform specific information?
  • Loading branch information
vivekverma-arista authored and mssonicbld committed Sep 10, 2024
1 parent 413c8ed commit 35d1688
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tests/common/dualtor/dual_tor_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -1837,3 +1837,4 @@ def disable_timed_oscillation_active_standby(duthosts, tbinfo):

for duthost in duthosts:
duthost.shell('sonic-db-cli CONFIG_DB HSET "MUX_LINKMGR|TIMED_OSCILLATION" "oscillation_enabled" "false"')
duthost.shell("config save -y")

0 comments on commit 35d1688

Please sign in to comment.