[T2-Chassis] - New tests for Reliable-TSA feature #13290

sanjair-git · 2024-06-13T19:31:28Z

Description of PR

Summary:
Fixes # (issue)

This PR has tests to verify the changes introduced as part of #[TSA] Reliable TSA: Addressing pizza box issues sonic-buildimage#19217. The original code PR for the feature is #Reliable TSA implementation sonic-buildimage#18928
HLD link for the feature: https://github.com/skeesara-nokia/SONiC/blob/master/doc/voq/Reliable_TSA.md
Basically, this PR has 20 test cases to verify the feature functionality and also few modifications on the tests introduced as part of PR Additional test cases to verify 'startup_tsa_tsb.service' - PR#18496 PR#12238 #12781

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

To verify the feature functionality and the code changes introduced as part of the PR #Reliable TSA implementation sonic-buildimage#18928

How did you do it?

Added 20 new test cases to verify feature in three sets.
Attaching test cases' description document here for further reference.
Reliable-TSA-Cases.xlsx

First set: TSA/TSB config event on the supervisor or line card. (8 cases)
test_sup_tsa_act_when_sup_duts_on_tsb_initially
test_sup_tsa_act_when_sup_on_tsb_duts_on_tsa_initially
test_sup_tsb_act_when_sup_on_tsa_duts_on_tsb_initially
test_sup_tsb_act_when_sup_and_duts_on_tsa_initially
test_dut_tsa_act_when_sup_duts_on_tsb_initially
test_dut_tsa_act_when_sup_on_tsa_duts_on_tsb_initially
test_dut_tsb_act_when_sup_on_tsb_duts_on_tsa_initially
test_dut_tsb_act_when_sup_and_duts_on_tsa_initially
Second set: Config event followed by certain action on the supervisor or line card. (8 cases)
test_sup_tsa_act_with_sup_reboot
test_sup_tsa_act_when_duts_on_tsa_with_sup_config_reload
test_dut_tsa_act_with_reboot_when_sup_dut_on_tsb_init
test_dut_tsa_with_conf_reload_when_sup_on_tsa_dut_on_tsb_init
test_sup_tsb_followed_by_dut_bgp_restart_when_sup_on_tsa_duts_on_tsb
test_sup_tsb_followed_by_dut_bgp_restart_when_sup_and_duts_on_tsa
test_dut_tsb_followed_by_dut_bgp_restart_when_sup_on_tsb_duts_on_tsa
test_dut_tsb_followed_by_dut_bgp_restart_when_sup_and_duts_on_tsa
Miscellaneous tests: Use cases with 'startup-tsa-tsb' service etc. (4 cases)
test_sup_tsa_when_startup_tsa_tsb_service_running
test_sup_tsb_when_startup_tsa_tsb_service_running
test_user_init_tsa_on_dut_followed_by_sup_tsa
test_user_init_tsa_on_dut_followed_by_sup_tsb

How did you verify/test it?

Ran all the above-mentioned test cases on a T2 chassis and made sure tests passed with expected behavior.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Reliable TSA test result:

Startup-tsa-tsb service test result:

Note: PR #12781 is pending merge, and this PR is dependent on that.

tjchadaga · 2024-07-05T22:33:28Z

tests/bgp/test_reliable_tsa.py

+
+
+@pytest.fixture(scope="module", autouse=True)
+def enable_disable_startup_tsa_tsb_service(duthosts):


can this be re-used from test_startup_tsa_tsb_service.py?

Yes right. Modified the code to re-use from test_startup_tsa_tsb_service.py file.

tjchadaga · 2024-07-10T08:09:39Z

tests/bgp/test_reliable_tsa.py

+    for linecard in duthosts.frontend_nodes:
+        dut_nbrhosts[linecard] = nbrhosts_to_dut(linecard, nbrhosts)
+        if not check_tsa_persistence_support(linecard):
+            pytest.skip("TSA persistence not supported in the image")


TSA persistence support on the linecard exists on all images that supports T2 and since this is a T2-only test, this check is not needed.

Should we be checking chassis-app-db for tsa_enabled field instead and skip if reliable tsa is not in the image?

Agreed. Removed the tsa_persistence_support check and added skip logic based on the chassis-app-db tsa_enabled field for all the test cases.

mssonicbld · 2024-07-10T21:10:46Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/bgp/test_startup_tsa_tsb_service.py:1164:1: F811 redefinition of unused 'test_user_init_tsa_while_service_run_on_dut' from line 743 tests/bgp/test_startup_tsa_tsb_service.py:1268:1: F811 redefinition of unused 'test_user_init_tsb_while_service_run_on_dut' from line 847 tests/bgp/test_startup_tsa_tsb_service.py:1360:1: F811 redefinition of unused 'test_user_init_tsb_on_sup_while_service_run_on_dut' from line 939 tests/bgp/test_startup_tsa_tsb_service.py:1484:1: F811 redefinition of unused 'test_tsa_tsb_timer_efficiency' from line 1059 flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

sanjair-git · 2024-08-02T14:57:50Z

This test PR is dependent on sonic-buildimage PR #(sonic-net/sonic-buildimage#19539)

abdosi · 2024-08-15T23:38:16Z

@tjchadaga: Are we good to merge this ?

sanjair-git · 2024-09-18T19:54:27Z

Latest test results for reference:

… cases

Recover dut in case of reboot failures or other issue flake8 fix flake8 blank line fix Include critical process check as well for dut recovery Typo fix intf check missing Fix for supervisor config reload test

…tsb tests Latest rebase changes

Do pre/post check only for t2 topo typo

sanjair-git requested a review from StormLiangMS as a code owner June 13, 2024 19:31

rlhui requested review from tjchadaga and abdosi June 19, 2024 17:21

abdosi added the Request for 202405 branch label Jul 10, 2024

tjchadaga reviewed Jul 10, 2024

View reviewed changes

fountzou mentioned this pull request Jul 10, 2024

Reliable TSA: Addressing review comments to use 'SpineRouter' in checks instead of 'voq' and fix few echo msgs. sonic-net/sonic-buildimage#19527

Merged

11 tasks

sanjair-git force-pushed the reliable-tsa branch from fec127c to b88efa2 Compare July 10, 2024 21:09

fountzou mentioned this pull request Jul 11, 2024

[202405][TSA] Reliable TSA: Conflict resolution for merging into 2024.05 branch sonic-net/sonic-buildimage#19539

Merged

11 tasks

sanjair-git force-pushed the reliable-tsa branch from 38f9de4 to ccdc07f Compare July 22, 2024 17:40

sanjair-git force-pushed the reliable-tsa branch from ccdc07f to cac60bf Compare August 2, 2024 21:40

sanjair-git force-pushed the reliable-tsa branch from cac60bf to f24de56 Compare August 12, 2024 20:08

sanjair-git force-pushed the reliable-tsa branch from f24de56 to 7fbca0b Compare August 27, 2024 20:22

rlhui assigned sanjair-git Sep 1, 2024

sanjair-git force-pushed the reliable-tsa branch 2 times, most recently from 30a0ca9 to 009a377 Compare September 5, 2024 17:35

sanjair-git force-pushed the reliable-tsa branch 3 times, most recently from f861d66 to 82fc585 Compare September 18, 2024 14:10

sanjair-git force-pushed the reliable-tsa branch from 82fc585 to 1b41635 Compare September 19, 2024 22:06

sanjair-git added 7 commits September 20, 2024 12:32

New tests for Reliable-TSA feature

56275fe

Reliable-TSA: Addressing review comments - PR#13290

388d127

Fixing rebase conflicts internal

8661ffb

Reliable-TSA: adjust autorestart state of bgp feature for bgp restart…

0f5994f

… cases

Recover dut for normal/abnormal reboot failures

b5a78d9

Recover dut in case of reboot failures or other issue flake8 fix flake8 blank line fix Include critical process check as well for dut recovery Typo fix intf check missing Fix for supervisor config reload test

Keep supervisor/linecards tsa-enabled config in sync for startup-tsa-…

7c393c1

…tsb tests Latest rebase changes

Refactor traffic_shift & traffic_shift_sup suites w.r.t reliable_tsa

bb71883

Do pre/post check only for t2 topo typo

sanjair-git force-pushed the reliable-tsa branch from 1b41635 to bb71883 Compare September 20, 2024 16:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[T2-Chassis] - New tests for Reliable-TSA feature #13290

[T2-Chassis] - New tests for Reliable-TSA feature #13290

sanjair-git commented Jun 13, 2024

tjchadaga Jul 5, 2024

sanjair-git Jul 10, 2024

tjchadaga Jul 10, 2024

sanjair-git Jul 10, 2024

mssonicbld commented Jul 10, 2024

sanjair-git commented Aug 2, 2024

abdosi commented Aug 15, 2024

sanjair-git commented Sep 18, 2024



		@pytest.fixture(scope="module", autouse=True)
		def enable_disable_startup_tsa_tsb_service(duthosts):

[T2-Chassis] - New tests for Reliable-TSA feature #13290

Are you sure you want to change the base?

[T2-Chassis] - New tests for Reliable-TSA feature #13290

Conversation

sanjair-git commented Jun 13, 2024

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

tjchadaga Jul 5, 2024

Choose a reason for hiding this comment

sanjair-git Jul 10, 2024

Choose a reason for hiding this comment

tjchadaga Jul 10, 2024

Choose a reason for hiding this comment

sanjair-git Jul 10, 2024

Choose a reason for hiding this comment

mssonicbld commented Jul 10, 2024

sanjair-git commented Aug 2, 2024

abdosi commented Aug 15, 2024

sanjair-git commented Sep 18, 2024