Reliable TSA: Addressing review comments to use 'SpineRouter' in checks instead of 'voq' and fix few echo msgs. #19527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of 'voq' and fix few echo msgs. Signed-off-by: fountzou <[email protected]>
11 tasks
|
Adding @mlok-nokia for viz |
abdosi
approved these changes
Jul 10, 2024
abdosi
approved these changes
Jul 10, 2024
|
@tjchadaga can you help review this |
|
Once PR#19539 gets approved and merged into 202405, cherry-pick conflict tag should become obsolete. |
11 tasks
tjchadaga
approved these changes
Jul 11, 2024
|
@rlhui can you help with merge of this. |
fountzou
added a commit
to fountzou/sonic-buildimage
that referenced
this pull request
Jul 12, 2024
… instead of 'voq' and fix few echo msgs. (sonic-net#19527) use 'SpineRouter' in checks instead of 'voq' and fix few echo msgs. Signed-off-by: fountzou <[email protected]>
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
… instead of 'voq' and fix few echo msgs. (sonic-net#19527) use 'SpineRouter' in checks instead of 'voq' and fix few echo msgs. Signed-off-by: fountzou <[email protected]>
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 1, 2024
… instead of 'voq' and fix few echo msgs. (sonic-net#19527) use 'SpineRouter' in checks instead of 'voq' and fix few echo msgs. Signed-off-by: fountzou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing review comments to use 'SpineRouter' in checks instead of 'voq' and fix few echo msgs.
Why I did it
To address review comments
Work item tracking
How I did it
How to verify it
Ran reliable_tsa tests from sonic-net/sonic-mgmt#13290 on a T2 chassis.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)