Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Add request spec for Refund Reasons & other minor edits #5822

Merged
merged 4 commits into from
Aug 14, 2024
Merged

[Admin] Add request spec for Refund Reasons & other minor edits #5822

merged 4 commits into from
Aug 14, 2024

Commits on Aug 13, 2024

  1. Remove unused load_refund_reason from controller 

    The general consensus is that this pattern persists across the new admin
controllers purely by virtue of a copy/paste carry-over as it looks like
it's not being used anywhere.
    @MadelineCollier
    MadelineCollier committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f243829 View commit details
    Browse the repository at this point in the history

  2. Ensure copy is consistent for admin refund reasons 

    The copy had a few inconsistencies and copy/paste errors.
    @MadelineCollier
    MadelineCollier committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    479011f View commit details
    Browse the repository at this point in the history

  3. Fix attribute reference 

    The human-readable output is the same regardless of which model we are
referencing here, (always "Active") but since this is the
RefundReason component, let's be consistent and reference that here.
    @MadelineCollier
    MadelineCollier committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    1e1de9c View commit details
    Browse the repository at this point in the history

  4. Add request spec for new admin refund reasons

    @MadelineCollier
    MadelineCollier committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    cb33038 View commit details
    Browse the repository at this point in the history