[Admin] Add request spec for Refund Reasons & other minor edits

[MadelineCollier]

• Remove unused load_refund_reason from controller
• Ensure copy is consistent for admin refund reasons
• Fix attribute reference
• Add request spec for new admin refund reasons

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.84%. Comparing base (7d2d97a) to head (cb33038).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5822      +/-   ##
==========================================
+ Coverage   88.79%   88.84%   +0.05%     
==========================================
  Files         737      737              
  Lines       17227    17224       -3     
==========================================
+ Hits        15296    15302       +6     
+ Misses       1931     1922       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MadelineCollier]

Requesting review from @rainerdema and @elia just to be sure that the removal of load_refund_reason looks okay to you guys (since Elia suggested the removal, and Rainer you introduced the method).

Hope the review request is not too spammy for you guys, thanks in advance! :)

[rainerdema]

Requesting review from @rainerdema and @elia just to be sure that the removal of load_refund_reason looks okay to you guys (since Elia suggested the removal, and Rainer you introduced the method).

Hey @MadelineCollier, I’ve investigated this a bit and I believe that most of these load_[resource_name] are due to copy-pasting from the first simple controller created that we all used as an example 😅

Considering that most of the controllers don’t even have a show action and that these aren't tied to any before_action, I believe it is safe to remove them.

I have identified the following controllers that have load_[resource_name] that seem unused:

• SolidusAdmin::AdjustmentReasonsController
• SolidusAdmin::RefundReasonsController
• SolidusAdmin::ReimbursementTypesController
• SolidusAdmin::ReturnReasonsController
• SolidusAdmin::ShippingCategoriesController
• SolidusAdmin::ShippingMethodsController
• SolidusAdmin::StockLocationsController
• SolidusAdmin::StoresController
• SolidusAdmin::StoreCreditReasonsController
• SolidusAdmin::TaxCategoriesController
• SolidusAdmin::TaxRatesController
• SolidusAdmin::UsersController
• SolidusAdmin::ZonesController

Hope the review request is not too spammy for you guys, thanks in advance! :)

Not at all! 🙏 I’m really glad to see the work on the admin is progressing.

[MadelineCollier]

Requesting review from @rainerdema and @elia just to be sure that the removal of load_refund_reason looks okay to you guys (since Elia suggested the removal, and Rainer you introduced the method).

Hey @MadelineCollier, I’ve investigated this a bit and I believe that most of these load_[resource_name] are due to copy-pasting from the first simple controller created that we all used as an example 😅

Considering that most of the controllers don’t even have a show action and that these aren't tied to any before_action, I believe it is safe to remove them.

I have identified the following controllers that have load_[resource_name] that seem unused:

• SolidusAdmin::AdjustmentReasonsController
• SolidusAdmin::RefundReasonsController
• SolidusAdmin::ReimbursementTypesController
• SolidusAdmin::ReturnReasonsController
• SolidusAdmin::ShippingCategoriesController
• SolidusAdmin::ShippingMethodsController
• SolidusAdmin::StockLocationsController
• SolidusAdmin::StoresController
• SolidusAdmin::StoreCreditReasonsController
• SolidusAdmin::TaxCategoriesController
• SolidusAdmin::TaxRatesController
• SolidusAdmin::UsersController
• SolidusAdmin::ZonesController

Hope the review request is not too spammy for you guys, thanks in advance! :)

Not at all! 🙏 I’m really glad to see the work on the admin is progressing.

Perfect! I'll look at removing those all today :) Thanks for the review!