Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Null Promotion Configuration in core #5744

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Use Null Promotion Configuration in core #5744

merged 2 commits into from
Jun 7, 2024

Commits on Jun 4, 2024

  1. Add :name attribute to promotion attributes in spec 

    With the NullPromotionConfiguration, the default promotion attributes
are an empty list. In order to test whether attributes can be deleted
from this list, we first have to add an attribute.
    @mamhoff
    mamhoff committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8eceec7 View commit details
    Browse the repository at this point in the history

  2. Use Null Promotion Configuration in core 

    We want to use the legacy `Spree::PromotionConfiguration` in the
solidus_legacy_promotions test suite.
    @mamhoff
    mamhoff committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    77a2aab View commit details
    Browse the repository at this point in the history