-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Null Promotion Configuration in core #5744
Conversation
09b93ba
to
82c98ae
Compare
82c98ae
to
636e27b
Compare
636e27b
to
a0c8ca0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I absolutely love the direction you're taking this.
bb52430
to
c7c2761
Compare
With the NullPromotionConfiguration, the default promotion attributes are an empty list. In order to test whether attributes can be deleted from this list, we first have to add an attribute.
We want to use the legacy `Spree::PromotionConfiguration` in the solidus_legacy_promotions test suite.
c7c2761
to
77a2aab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5744 +/- ##
===========================================
+ Coverage 75.56% 88.71% +13.15%
===========================================
Files 711 711
Lines 17796 16886 -910
===========================================
+ Hits 13447 14980 +1533
+ Misses 4349 1906 -2443 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary
We want to use the legacy
Spree::LegacyPromotions::Configuration
only in the solidus_legacy_promotions test suite. In the core test suite, we use theSpree::Core::NullPromotionConfiguration
. This will finally allow us to move all the classes and specs to thesolidus_legacy_promotions
gem in a future PR.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: