Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update Binder to launch into JupyterLab environment #2252

Merged
merged 5 commits into from
Jul 15, 2023
Merged

docs: Update Binder to launch into JupyterLab environment #2252

merged 5 commits into from
Jul 15, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jul 15, 2023 •
edited
Loading

Description

  • Install ipywidgets and ipympl to have interactive IPython widgets in modern JupyterLab.
  • Use from IPython.display import display to avoid using deprecated APIs.
  • Use %matplotlib widget to get interactive matplotlib in JupyterLab.
  • Use 'labpath' to open up files in JupyterLab.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Install ipywidgets and ipympl to have interactive IPython widgets in
  modern JupyterLab.
* Use from IPython.display import display to avoid using deprecated APIs.
* Use %matplotlib widget to get interactive matplotlib in JupyterLab.
* Use 'labpath' to open up files in JupyterLab.

@matthewfeickert matthewfeickert added docs Documentation related need-to-backport tmp label until can be backported to patch release branch labels Jul 15, 2023
@matthewfeickert matthewfeickert self-assigned this Jul 15, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@matthewfeickert
Copy link
Member Author

Preview on fork: Binder

@codecov
Copy link

codecov bot commented Jul 15, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (9797a21) 98.30% compared to head (5aad3d2) 98.30%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2252   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4534     4534           
  Branches      802      802           
=======================================
  Hits         4457     4457           
  Misses         45       45           
  Partials       32       32
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.09% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.11 96.31% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert marked this pull request as ready for review July 15, 2023 21:55
@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert added the Binder Contributing to having Binder build and Binder images run smoothly label Jul 15, 2023
@matthewfeickert matthewfeickert merged commit ff9cb94 into main Jul 15, 2023
18 checks passed
@matthewfeickert matthewfeickert deleted the docs/update-binder-to-jupyterlab branch July 15, 2023 22:01
@matthewfeickert matthewfeickert mentioned this pull request Jul 18, 2023
Merged
4 tasks
matthewfeickert added a commit that referenced this pull request Jul 18, 2023
@matthewfeickert
fix: Add ipympl to 'test' extra (#2255)
fb604e8 
* Add ipympl>=0.3.0 to the 'test' extra environment as it is used in the
  notebooks as of PR #2252. The lower bound of v0.3.0 is chosen as this
  corresponds in time with the 'contrib' lower bound on matplotlib of
  matplotlib>=3.0.0.
* Amends PR #2252.
matthewfeickert added a commit that referenced this pull request Aug 16, 2023
@matthewfeickert
fix: Add ipympl to 'test' extra (#2255)
809d301 
* Add ipympl>=0.3.0 to the 'test' extra environment as it is used in the
  notebooks as of PR #2252. The lower bound of v0.3.0 is chosen as this
  corresponds in time with the 'contrib' lower bound on matplotlib of
  matplotlib>=3.0.0.
* Amends PR #2252.
matthewfeickert added a commit that referenced this pull request Aug 16, 2023
@matthewfeickert
docs: Update Binder to launch into JupyterLab environment (#2252)
a656c1a 
* Install ipywidgets and ipympl to have interactive IPython widgets in
  modern JupyterLab.
* Use from IPython.display import display to avoid using deprecated APIs.
* Use %matplotlib widget to get interactive matplotlib in JupyterLab.
* Use 'labpath' to open up file paths in JupyterLab.
@matthewfeickert matthewfeickert mentioned this pull request Aug 16, 2023
Merged
4 tasks
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Aug 16, 2023
matthewfeickert added a commit that referenced this pull request Aug 16, 2023
@matthewfeickert
docs(backport): Update docs build requirements (#2281)
f97b885 
* Backport components of:
   - PR #2252
   - PR #2255
   - PR #2267
   - PR #2271
   - PR #2272
   - PR #2276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewfeickert matthewfeickert

Labels
Binder Contributing to having Binder build and Binder images run smoothly docs Documentation related
Projects
pyhf v0.8.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthewfeickert