Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(backport): Update docs build requirements #2281

Merged
merged 5 commits into from
Aug 16, 2023
Merged

docs(backport): Update docs build requirements #2281

merged 5 commits into from
Aug 16, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Aug 16, 2023 •
edited
Loading

Description

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Backport components of:
   - PR https://github.com/scikit-hep/pyhf/pull/2230
   - PR https://github.com/scikit-hep/pyhf/pull/2252
   - PR https://github.com/scikit-hep/pyhf/pull/2255
   - PR https://github.com/scikit-hep/pyhf/pull/2267
   - PR https://github.com/scikit-hep/pyhf/pull/2271
   - PR https://github.com/scikit-hep/pyhf/pull/2272
   - PR https://github.com/scikit-hep/pyhf/pull/2276

@matthewfeickert
docs(backport): Update docs build requirements
53ad991 
* Backport components of:
   - PR https://github.com/scikit-hep/pyhf/pull/ 2252
   - PR https://github.com/scikit-hep/pyhf/pull/ 2255
   - PR https://github.com/scikit-hep/pyhf/pull/ 2267
   - PR https://github.com/scikit-hep/pyhf/pull/ 2271
   - PR https://github.com/scikit-hep/pyhf/pull/ 2272
   - PR https://github.com/scikit-hep/pyhf/pull/ 2276
@matthewfeickert
docs: Require sphinx-rtd-theme compatible with Sphinx 7 (#2271)
73208e4 
* Update lower bound on sphinx-rtd-theme to v1.3.0rc1 to ensure
  compatibility with Sphinx v7+.
   - c.f. readthedocs/sphinx_rtd_theme#1463
   - As soon as sphinx-rtd-theme v1.3.0 is released on PyPI the lower
     bound should be updated to reflect this stable release. The release
     candidate is being used to unbreak CI.
* Update lower bound of Sphinx to v7.0.0 for consistency.
@matthewfeickert
Backport 2267
32aeec8
@matthewfeickert
fix: Add ipympl to 'test' extra (#2255)
809d301 
* Add ipympl>=0.3.0 to the 'test' extra environment as it is used in the
  notebooks as of PR #2252. The lower bound of v0.3.0 is chosen as this
  corresponds in time with the 'contrib' lower bound on matplotlib of
  matplotlib>=3.0.0.
* Amends PR #2252.
@matthewfeickert
docs: Update Binder to launch into JupyterLab environment (#2252)
a656c1a 
* Install ipywidgets and ipympl to have interactive IPython widgets in
  modern JupyterLab.
* Use from IPython.display import display to avoid using deprecated APIs.
* Use %matplotlib widget to get interactive matplotlib in JupyterLab.
* Use 'labpath' to open up file paths in JupyterLab.
@matthewfeickert matthewfeickert added docs Documentation related fix A bug fix backport Backport PRs from main to release branch labels Aug 16, 2023
@matthewfeickert matthewfeickert self-assigned this Aug 16, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codecov
Copy link

codecov bot commented Aug 16, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.7.x@b3c5ead). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@                Coverage Diff                @@
##             release/v0.7.x    #2281   +/-   ##
=================================================
  Coverage                  ?   98.25%           
=================================================
  Files                     ?       69           
  Lines                     ?     4537           
  Branches                  ?      802           
=================================================
  Hits                      ?     4458           
  Misses                    ?       47           
  Partials                  ?       32
Flag Coverage Δ
contrib 27.55% <0.00%> (?)
doctest 61.07% <0.00%> (?)
unittests-3.10 96.27% <0.00%> (?)
unittests-3.11 96.27% <0.00%> (?)
unittests-3.7 96.25% <0.00%> (?)
unittests-3.8 96.29% <0.00%> (?)
unittests-3.9 96.31% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit f97b885 into release/v0.7.x Aug 16, 2023
17 checks passed
@matthewfeickert matthewfeickert deleted the backport/get-docs-building branch August 16, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewfeickert matthewfeickert

Labels
backport Backport PRs from main to release branch docs Documentation related fix A bug fix
Projects
pyhf v0.7.3
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthewfeickert