Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added our solar system #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added our solar system #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion earth.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,43 @@
[
{
"name": "mercury",
"parent": "solar system"
},
{
"name": "venus",
"parent": "solar system"
},
{
"name": "earth",
"parent": "solar system"
},
{
"name": "mars",
"parent": "solar system"
},
{
"name": "jupiter",
"parent": "solar system"
},
{
"name": "saturn",
"parent": "solar system"
},
{
"name": "neptune",
"parent": "solar system"
},
{
"name": "uranus",
"parent": "solar system"
},
{
"name": "pluto",
"parent": "solar system"
},
{
"name": "earth",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you have already added earth on line 11, you can remove the earth's entry from here to prevent duplication of data. Update the PR once, done so that I can merge it! :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe we could have separate files for different planets too as that would be more consistent, and there is a few data about Mars already.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! That's the eventual plan, and also why this file is currently named as earth.json. If you feel there is sufficient data about other planets, then we can create separate files for each planet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated earth's parent to solar system, but I think having another file for Mars would be the ideal thing to do.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case go for it. Create a new file called mars.json with details of all places on mars and send it in. Once this is done, we can restructure a bit to create a better hierarchy.

"parent": ""
"parent": "solar system"
},
{
"name": "africa",
Expand Down