Added our solar system #1
Conversation
| "name": "pluto", | ||
| "parent": "solar system" | ||
| }, | ||
| { | ||
| "name": "earth", |
There was a problem hiding this comment.
Since you have already added earth on line 11, you can remove the earth's entry from here to prevent duplication of data. Update the PR once, done so that I can merge it! :)
There was a problem hiding this comment.
Hmm, maybe we could have separate files for different planets too as that would be more consistent, and there is a few data about Mars already.
There was a problem hiding this comment.
Yup! That's the eventual plan, and also why this file is currently named as earth.json. If you feel there is sufficient data about other planets, then we can create separate files for each planet.
There was a problem hiding this comment.
I've updated earth's parent to solar system, but I think having another file for Mars would be the ideal thing to do.
There was a problem hiding this comment.
In that case go for it. Create a new file called mars.json with details of all places on mars and send it in. Once this is done, we can restructure a bit to create a better hierarchy.
|
Since you have already added earth on line 11, you can remove the earth's entry from here to prevent duplication of data. Update the PR once, done so that I can merge it! :) |
|
Still need to create a proper structure out of this. Maybe split planets into different files and group files into directories of solar systems? |
|
Hmm, that would be a good idea. We should also have an upper hierarchy for gallaxies. |
|
I think a directory structure of the pattern: "Universe" -> "Galaxies" -> "Solar Systems" -> "Planets" would make sense here. |
|
Agreed :) |
|
Can you make the required changes and update this PR so that I can merge this? |
No description provided.