Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect regex for handling the hostnames #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: incorrect regex for handling the hostnames #36

wants to merge 2 commits into from

Conversation

RishabhKodes
Copy link

Removed hardcoded reject for all hostnames containing '0'

Replaced with regex search checking for "ending with 0" instead.

# Before
reject('search', '0')

# After
reject('regex', '0$')

@RishabhKodes RishabhKodes mentioned this pull request Aug 6, 2024
Open
@RishabhKodes RishabhKodes changed the title fixed incorrect regex for handling the hostnames fix: incorrect regex for handling the hostnames Aug 6, 2024
@Wabri Wabri self-requested a review August 9, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wabri Wabri Wabri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RishabhKodes @Wabri