Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap*scaleout: fix incorrect regex for hostname handling #35

Open
sean-freeman opened this issue Jul 31, 2024 · 1 comment
Open

sap*scaleout: fix incorrect regex for hostname handling #35

sean-freeman opened this issue Jul 31, 2024 · 1 comment

Comments

@sean-freeman
Copy link
Member

Fix hardcoded hostnames search to regex

  • Removed hardcoded reject for all hostnames containing '0'
  • Replaced with regex search checking for "ending with 0" instead.
# Before
reject('search', '0')

# After
reject('regex', '0$')
@RishabhKodes
Copy link

Fix for this, #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants