Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicity pass context for salt-ssh state calls #63184

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Dec 2, 2022

Fixes: #60003

@Ch3LL Ch3LL requested a review from a team as a code owner December 2, 2022 15:14
@Ch3LL Ch3LL requested review from cmcmarrow and removed request for a team December 2, 2022 15:14
@Ch3LL Ch3LL changed the title [WIP] Explicity pass context for salt-ssh highstate [WIP] Explicity pass context for salt-ssh state calls Dec 2, 2022
@Ch3LL Ch3LL changed the title [WIP] Explicity pass context for salt-ssh state calls Explicity pass context for salt-ssh state calls Dec 2, 2022
Rudd-O
Rudd-O previously approved these changes Dec 5, 2022
Copy link

@Rudd-O Rudd-O left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa this looks nice. Honestly, the functions being called should have never gained optional context parameters — that pattern was always a recipe that introduced fragility for maintainers and hid code smells. Hoping that Salt code will gain some type checking soon, to make these problems easier to solve.

Please ensure that your PR complies with the stated requirements for merging — including but not limited to fixing the testing. Thanks.

@Ch3LL Ch3LL added the Sulfur v3006.0 release code name and version label Dec 5, 2022
cmcmarrow
cmcmarrow previously approved these changes Dec 6, 2022
Copy link
Contributor

@cmcmarrow cmcmarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably get the commits signing again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sulfur v3006.0 release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] salt-ssh support for extra_filerefs in Saltfile is broken
3 participants