[BUG] salt-ssh jinja import from doesn't work due to error jinja2.exceptions.TemplateNotFound #61174

dosercz · 2021-11-03T10:33:14Z

Description
Jinja import from doesn't work with salt-ssh due to error jinja2.exceptions.TemplateNotFound. It works fine while running same setup via salt-minion, so problem is probably in salt-ssh.

Debug output:

[DEBUG   ] In saltenv 'base', looking at rel_path 'salt/repo.sls' to resolve 'salt://salt/repo.sls'
[DEBUG   ] In saltenv 'base', ** considering ** path '/var/tmp/.root_29fa9c_salt/running_data/var/cache/salt/minion/files/base/salt/repo.sls' to resolve 'salt://salt/repo.sls'
[DEBUG   ] compile template: /var/tmp/.root_29fa9c_salt/running_data/var/cache/salt/minion/files/base/salt/repo.sls
[DEBUG   ] Jinja search path: ['/var/tmp/.root_29fa9c_salt/running_data/var/cache/salt/minion/files/base']
[DEBUG   ] In saltenv 'base', looking at rel_path 'salt/map.jinja' to resolve 'salt://salt/map.jinja'
[DEBUG   ] In saltenv 'base', ** considering ** path '/var/cache/salt/master/files/base/salt/map.jinja' to resolve 'salt://salt/map.jinja'
[DEBUG   ] Fetching file from saltenv 'base', ** attempting ** 'salt://salt/map.jinja'
[DEBUG   ] No dest file found
[INFO    ] Fetching file from saltenv 'base', ** done ** 'salt/map.jinja'
[DEBUG   ] Jinja Error
[DEBUG   ] Exception:
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/salt/utils/templates.py", line 502, in render_jinja_tmpl
    output = template.render(**decoded_context)
  File "/usr/lib/python3/dist-packages/jinja2/environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "/usr/lib/python3/dist-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/lib/python3/dist-packages/jinja2/_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "<template>", line 1, in top-level template code
  File "/usr/lib/python3/dist-packages/salt/utils/jinja.py", line 198, in get_source
    raise TemplateNotFound(template)
jinja2.exceptions.TemplateNotFound: salt/map.jinja
[DEBUG   ] Out:
[DEBUG   ] Line: 1
[DEBUG   ] TmplStr: {% from "salt/map.jinja" import salt with context %}

But file /var/cache/salt/master/files/base/salt/map.jinja is present in salt master FS.

Setup
Install salt-master + salt-ssh and setup roster file. The problem occurs at Debian 9 VM with salt v3004. Tested with salt v 2019.2.8 without any problem. No minion installed at target machine, target machine is clean Debian installation.

Steps to Reproduce the behavior
Run salt-ssh \* state.sls test with these states:
test/init.sls:

include:
  - .repo

...

test/repo.sls:

{% from "test/map.jinja" import salt with context %}

...

test/map.jinja:

{% set salt = salt['grains.filter_by']({
  'stretch': {
    'repo': 'deb [arch=amd64] https://repo.saltproject.io/py3/debian/9/amd64/3004 stretch main',
    'key_url': 'https://repo.saltproject.io/py3/debian/9/amd64/3004/salt-archive-keyring.gpg'
  },
  'buster': {
    'repo': 'deb [arch=amd64] https://repo.saltproject.io/py3/debian/10/amd64/3004 buster main',
    'key_url': 'https://repo.saltproject.io/py3/debian/10/amd64/3004/salt-archive-keyring.gpg'
  },
}, 'lsb_distrib_codename') %}

Expected behavior
No error and success as running salt via salt-minion.

Versions Report

salt --versions-report

``` Salt Version: Salt: 3004

Dependency Versions:
cffi: Not Installed
cherrypy: Not Installed
dateutil: 2.5.3
docker-py: Not Installed
gitdb: 2.0.0
gitpython: 2.1.1
Jinja2: 2.9.4
libgit2: Not Installed
M2Crypto: Not Installed
Mako: Not Installed
msgpack: 0.6.2
msgpack-pure: Not Installed
mysql-python: Not Installed
pycparser: Not Installed
pycrypto: Not Installed
pycryptodome: 3.6.1
pygit2: Not Installed
Python: 3.5.3 (default, Apr 5 2021, 09:00:41)
python-gnupg: Not Installed
PyYAML: 3.12
PyZMQ: 17.1.2
smmap: 2.0.1
timelib: Not Installed
Tornado: 4.5.3
ZMQ: 4.2.1

System Versions:
dist: debian 9 stretch
locale: UTF-8
machine: x86_64
release: 4.9.0-16-amd64
system: Linux
version: Debian GNU/Linux 9 stretch

</details>

The text was updated successfully, but these errors were encountered:

OrangeDog · 2021-11-06T18:38:00Z

This looks like a duplicate of #21370.
You can work around it using extra_filerefs.

dosercz · 2021-11-06T23:10:41Z

I have tried workaround with extra_filerefs, but it doesn't help in my case. So it's probably different problem. It's strange, that we were using this for years without any problem, but now it's broken in version 3004. Last tested previous version is 2019.2.8, where I can confirm no problems with that.

baby-gnu · 2021-12-06T20:29:04Z

Hello.

I made some tests and found it broke at 3003.

Regards.

frenkye · 2021-12-14T12:33:19Z

I just upgraded our master from 3002.7 to 3004 and got same error calling state over salt-ssh like, all formulas worked ok when called from master->minion or on minion via salt-call with no problem.

SSH command:

salt-ssh -v "*" state.sls prometheus

and i was getting error from all sls files:

    - Rendering SLS 'base:prometheus.node' failed: Jinja error: prometheus/map.jinja
    ...
      {% from "prometheus/map.jinja" import binExporter with context %}    <======================

I did try adding --extra-filerefs, but it did not helped. Since i have under this prometheus defined all kind of services, i wanted to lower the error output i was getting and called

salt-ssh -v "*" state.sls prometheus.nginx

To my suprise did get exececuted without problem and after that full formula works as well. The only thing maybe some corrupted cache after upgrade?

nergdron · 2022-01-25T22:32:24Z

I'm running into this issue now with 3004 as well. I've never had to use extra_filerefs previously, but now it seems busted. I've noticed that, without adding extra_filerefs, if I call a specific state that references the include, it works. but if I call the highstate (such as with salt-ssh hostname state.apply) then it breaks as mentioned here.

is there a workaround that actually works for this case? and is the root cause potentially the cache dir issue that seems to be causing #60003?

TeddyAndrieux · 2022-01-31T09:18:49Z

To me, it's the same as this one #60620 (that is wrongly closed as duplicates)

To me, this regression get introduced in 3003

Rudd-O · 2022-02-08T17:08:57Z

I'm hit by the same bug. It's incredible to me that salt-ssh continues to have these kinds of bugs in 2022. I'm at the breaking point where I'm strongly considering the option raised by another commenter in a separate bug: perhaps it's just better to go back to Ansible.

nergdron · 2022-02-08T17:56:26Z

@Rudd-O yeah, we just finished a migration from ansible to salt-ssh, just in time for all these 3003 bugs. it's been a real headache. def feels like salt-ssh isn't getting the regression testing / QA / dev love as the rest of the stack, which is really unfortunate.

baby-gnu · 2022-02-08T19:33:03Z

I did not try the proposed patch but I'll try to have a look at it.

I wonder if salt-ssh workgroup is working or not…

mattboston · 2022-03-01T15:43:12Z

I'm having the same issue on 3004.1 on CentOS 7. Added the patch #60620 and #60003 and neither of them solved the issue. Here's the configs we're using:

/etc/salt/roster:

  host: 10.10.10.123

/etc/salt/master.d/ssh_defaults.conf

roster_defaults:
  user: salt-user
  priv: /etc/salt/pki/salt-ser
  thin_dir: /etc/salt
  sudo: True
#  tty: True

ssh_minion_opts:
  gpg_keydir: /etc/salt/gpgkeys/

babs · 2022-03-15T00:31:34Z

The latest patch updated for 3004 me tionned in #60003 worked for me

baby-gnu · 2022-04-08T11:46:47Z

Hello, #61895 fixes my issues.

johnnybubonic · 2023-01-16T08:51:30Z

Still getting this with a 3005.1.4 master when I attempt a relative jinja import (from './vars.jinja' import...).

stratusjerry · 2023-01-20T16:28:35Z

Still getting this with a 3005.1.4 master when I attempt a relative jinja import (from './vars.jinja' import...).

I believe the fix is #63184 which is not in 3005.1.4 but scheduled for 3006

nergdron · 2023-01-20T17:12:35Z

so when is 3006 getting released?

TeddyAndrieux · 2023-07-24T15:26:15Z

Any chance this fix get backported to 3005 one day, because right now we are stuck with 3002.9 (and cannot upgrade for the moment to 3006 since moving to onedir is quite a huge change on our side)

Rudd-O · 2023-08-02T23:37:32Z

onedir

?

jpmckinney · 2023-08-03T13:54:00Z

@Rudd-O https://docs.saltproject.io/salt/install-guide/en/latest/topics/upgrade-to-onedir.html#upgrade-to-onedir

SkypLabs · 2024-03-15T17:32:03Z

The bug seems gone for me in version 3007.0. Anyone can confirm to close this issue?

aarnaud · 2024-03-15T18:44:25Z

Didn't notice 3007 was release, generally I wait .1 or .2 before upgrading. I had too much issue in the past with upgrading. I will try to test on my labs

baby-gnu · 2024-03-18T08:03:47Z

Hello @SkypLabs

The bug seems gone for me in version 3007.0. Anyone can confirm to close this issue?

My tests as described in 31531 still do not work:

salt-ssh --versions-report

Salt Version:
          Salt: 3007.0
 
Python Version:
        Python: 3.10.13 (main, Feb 19 2024, 03:31:20) [GCC 11.2.0]
 
Dependency Versions:
          cffi: 1.16.0
      cherrypy: 18.8.0
      dateutil: 2.8.2
     docker-py: Not Installed
         gitdb: Not Installed
     gitpython: Not Installed
        Jinja2: 3.1.3
       libgit2: 1.7.2
  looseversion: 1.3.0
      M2Crypto: Not Installed
          Mako: Not Installed
       msgpack: 1.0.7
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     packaging: 23.1
     pycparser: 2.21
      pycrypto: Not Installed
  pycryptodome: 3.19.1
        pygit2: 1.14.1
  python-gnupg: 0.5.2
        PyYAML: 6.0.1
         PyZMQ: 25.1.2
        relenv: 0.15.1
         smmap: Not Installed
       timelib: 0.3.0
       Tornado: 6.3.3
           ZMQ: 4.3.4
 
Salt Package Information:
  Package Type: onedir
 
System Versions:
          dist: debian n/a trixie
        locale: utf-8
       machine: x86_64
       release: 6.7.9-amd64
        system: Linux
       version: Debian GNU/Linux n/a trixie

salt-ssh minion1 state.show_sls

[ERROR   ] Rendering exception occurred
Traceback (most recent call last):
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/templates.py", line 468, in render_jinja_tmpl
    output = template.render(**decoded_context)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/jinja2/environment.py", line 1301, in render
    self.environment.handle_exception()
  File "/opt/saltstack/salt/lib/python3.10/site-packages/jinja2/environment.py", line 936, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "<template>", line 3, in top-level template code
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/jinja.py", line 198, in get_source
    raise TemplateNotFound(template)
jinja2.exceptions.TemplateNotFound: test-import/map.jinja

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/templates.py", line 209, in render_tmpl
    output = render_str(tmplstr, context, tmplpath)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/templates.py", line 512, in render_jinja_tmpl
    raise SaltRenderError(
salt.exceptions.SaltRenderError: Jinja error: test-import/map.jinja
Traceback (most recent call last):
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/templates.py", line 468, in render_jinja_tmpl
    output = template.render(**decoded_context)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/jinja2/environment.py", line 1301, in render
    self.environment.handle_exception()
  File "/opt/saltstack/salt/lib/python3.10/site-packages/jinja2/environment.py", line 936, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "<template>", line 3, in top-level template code
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/jinja.py", line 198, in get_source
    raise TemplateNotFound(template)
jinja2.exceptions.TemplateNotFound: test-import/map.jinja

; line 3

---
# -*- mode: salt; coding: utf-8 -*-
# vim: ft=sls
{% from "test-import/map.jinja" import mapdata %}    <======================

test-import/absolute/test.nop:
  test.nop:
    - name: {{ mapdata | json }}

[...]
---
[CRITICAL] Rendering SLS 'base:test-import.absolute' failed: Jinja error: test-import/map.jinja
Traceback (most recent call last):
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/templates.py", line 468, in render_jinja_tmpl
    output = template.render(**decoded_context)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/jinja2/environment.py", line 1301, in render
    self.environment.handle_exception()
  File "/opt/saltstack/salt/lib/python3.10/site-packages/jinja2/environment.py", line 936, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "<template>", line 3, in top-level template code
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/jinja.py", line 198, in get_source
    raise TemplateNotFound(template)
jinja2.exceptions.TemplateNotFound: test-import/map.jinja

; line 3

---
# -*- mode: salt; coding: utf-8 -*-
# vim: ft=sls
{% from "test-import/map.jinja" import mapdata %}    <======================

test-import/absolute/test.nop:
  test.nop:
    - name: {{ mapdata | json }}

[...]
---
[ERROR   ] Rendering exception occurred
Traceback (most recent call last):
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/templates.py", line 468, in render_jinja_tmpl
    output = template.render(**decoded_context)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/jinja2/environment.py", line 1301, in render
    self.environment.handle_exception()
  File "/opt/saltstack/salt/lib/python3.10/site-packages/jinja2/environment.py", line 936, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "<template>", line 3, in top-level template code
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/jinja.py", line 198, in get_source
    raise TemplateNotFound(template)
jinja2.exceptions.TemplateNotFound: ./map.jinja

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/templates.py", line 209, in render_tmpl
    output = render_str(tmplstr, context, tmplpath)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/templates.py", line 512, in render_jinja_tmpl
    raise SaltRenderError(
salt.exceptions.SaltRenderError: Jinja error: ./map.jinja
Traceback (most recent call last):
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/templates.py", line 468, in render_jinja_tmpl
    output = template.render(**decoded_context)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/jinja2/environment.py", line 1301, in render
    self.environment.handle_exception()
  File "/opt/saltstack/salt/lib/python3.10/site-packages/jinja2/environment.py", line 936, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "<template>", line 3, in top-level template code
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/jinja.py", line 198, in get_source
    raise TemplateNotFound(template)
jinja2.exceptions.TemplateNotFound: ./map.jinja

; line 3

---
# -*- mode: salt; coding: utf-8 -*-
# vim: ft=sls
{% from "./map.jinja" import mapdata %}    <======================

test-import/relative/test.nop:
  test.nop:
    - name: {{ mapdata | json }}

[...]
---
[CRITICAL] Rendering SLS 'base:test-import.relative' failed: Jinja error: ./map.jinja
Traceback (most recent call last):
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/templates.py", line 468, in render_jinja_tmpl
    output = template.render(**decoded_context)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/jinja2/environment.py", line 1301, in render
    self.environment.handle_exception()
  File "/opt/saltstack/salt/lib/python3.10/site-packages/jinja2/environment.py", line 936, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "<template>", line 3, in top-level template code
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/jinja.py", line 198, in get_source
    raise TemplateNotFound(template)
jinja2.exceptions.TemplateNotFound: ./map.jinja

; line 3

---
# -*- mode: salt; coding: utf-8 -*-
# vim: ft=sls
{% from "./map.jinja" import mapdata %}    <======================

test-import/relative/test.nop:
  test.nop:
    - name: {{ mapdata | json }}

[...]
---
minion1:
    - Rendering SLS 'base:test-import.absolute' failed: Jinja error: test-import/map.jinja
      Traceback (most recent call last):
        File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/templates.py", line 468, in render_jinja_tmpl
          output = template.render(**decoded_context)
        File "/opt/saltstack/salt/lib/python3.10/site-packages/jinja2/environment.py", line 1301, in render
          self.environment.handle_exception()
        File "/opt/saltstack/salt/lib/python3.10/site-packages/jinja2/environment.py", line 936, in handle_exception
          raise rewrite_traceback_stack(source=source)
        File "<template>", line 3, in top-level template code
        File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/jinja.py", line 198, in get_source
          raise TemplateNotFound(template)
      jinja2.exceptions.TemplateNotFound: test-import/map.jinja
      
      ; line 3
      
      ---
      # -*- mode: salt; coding: utf-8 -*-
      # vim: ft=sls
      {% from "test-import/map.jinja" import mapdata %}    <======================
      
      test-import/absolute/test.nop:
        test.nop:
          - name: {{ mapdata | json }}
      
      [...]
      ---
    - Rendering SLS 'base:test-import.relative' failed: Jinja error: ./map.jinja
      Traceback (most recent call last):
        File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/templates.py", line 468, in render_jinja_tmpl
          output = template.render(**decoded_context)
        File "/opt/saltstack/salt/lib/python3.10/site-packages/jinja2/environment.py", line 1301, in render
          self.environment.handle_exception()
        File "/opt/saltstack/salt/lib/python3.10/site-packages/jinja2/environment.py", line 936, in handle_exception
          raise rewrite_traceback_stack(source=source)
        File "<template>", line 3, in top-level template code
        File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/jinja.py", line 198, in get_source
          raise TemplateNotFound(template)
      jinja2.exceptions.TemplateNotFound: ./map.jinja
      
      ; line 3
      
      ---
      # -*- mode: salt; coding: utf-8 -*-
      # vim: ft=sls
      {% from "./map.jinja" import mapdata %}    <======================
      
      test-import/relative/test.nop:
        test.nop:
          - name: {{ mapdata | json }}
      
      [...]
      ---

It was fixed by #61895 (#31531 (comment)) but was broken again after (I don't know when).

dosercz added Bug broken, incorrect, or confusing behavior needs-triage labels Nov 3, 2021

github-actions bot assigned s0undt3ch Nov 3, 2021

OrangeDog added Duplicate Duplicate of another issue or PR - will be closed Salt-SSH and removed needs-triage labels Nov 6, 2021

OrangeDog added Regression The issue is a bug that breaks functionality known to work in previous releases. severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around and removed Duplicate Duplicate of another issue or PR - will be closed labels Nov 8, 2021

OrangeDog added this to the Approved milestone Nov 8, 2021

OrangeDog mentioned this issue Mar 14, 2022

Cannot use gitfs with salt-ssh #23576

Closed

OrangeDog added severity-high 2nd top severity, seen by most users, causes major problems and removed severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around labels Mar 14, 2022

kaszuba mentioned this issue Apr 1, 2022

Make sure SaltCacheLoader use correct fileclient #61895

Closed

mwarkentin mentioned this issue Mar 9, 2023

add jinja cached_client patch getsentry/salt#2

Merged

s0undt3ch removed their assignment Jun 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG] salt-ssh jinja import from doesn't work due to error jinja2.exceptions.TemplateNotFound #61174

[BUG] salt-ssh jinja import from doesn't work due to error jinja2.exceptions.TemplateNotFound #61174

dosercz commented Nov 3, 2021

OrangeDog commented Nov 6, 2021 •

edited

Loading

dosercz commented Nov 6, 2021 •

edited

Loading

baby-gnu commented Dec 6, 2021

frenkye commented Dec 14, 2021

nergdron commented Jan 25, 2022 •

edited

Loading

TeddyAndrieux commented Jan 31, 2022

Rudd-O commented Feb 8, 2022

nergdron commented Feb 8, 2022

baby-gnu commented Feb 8, 2022

mattboston commented Mar 1, 2022

babs commented Mar 15, 2022

baby-gnu commented Apr 8, 2022

johnnybubonic commented Jan 16, 2023

stratusjerry commented Jan 20, 2023

nergdron commented Jan 20, 2023

TeddyAndrieux commented Jul 24, 2023

Rudd-O commented Aug 2, 2023

jpmckinney commented Aug 3, 2023

SkypLabs commented Mar 15, 2024

aarnaud commented Mar 15, 2024 •

edited

Loading

baby-gnu commented Mar 18, 2024

[BUG] salt-ssh jinja import from doesn't work due to error jinja2.exceptions.TemplateNotFound #61174

[BUG] salt-ssh jinja import from doesn't work due to error jinja2.exceptions.TemplateNotFound #61174

Comments

dosercz commented Nov 3, 2021

OrangeDog commented Nov 6, 2021 • edited Loading

dosercz commented Nov 6, 2021 • edited Loading

baby-gnu commented Dec 6, 2021

frenkye commented Dec 14, 2021

nergdron commented Jan 25, 2022 • edited Loading

TeddyAndrieux commented Jan 31, 2022

Rudd-O commented Feb 8, 2022

nergdron commented Feb 8, 2022

baby-gnu commented Feb 8, 2022

mattboston commented Mar 1, 2022

babs commented Mar 15, 2022

baby-gnu commented Apr 8, 2022

johnnybubonic commented Jan 16, 2023

stratusjerry commented Jan 20, 2023

nergdron commented Jan 20, 2023

TeddyAndrieux commented Jul 24, 2023

Rudd-O commented Aug 2, 2023

jpmckinney commented Aug 3, 2023

SkypLabs commented Mar 15, 2024

aarnaud commented Mar 15, 2024 • edited Loading

baby-gnu commented Mar 18, 2024

OrangeDog commented Nov 6, 2021 •

edited

Loading

dosercz commented Nov 6, 2021 •

edited

Loading

nergdron commented Jan 25, 2022 •

edited

Loading

aarnaud commented Mar 15, 2024 •

edited

Loading