Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Correctly match and tag containers #252

Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix(ci): Correctly match and tag containers #252

merged 1 commit into from
Jan 30, 2023

Commits on Jan 30, 2023

  1. fix(ci): Correctly match and tag containers 

    Release tags have been `vM.m` which wasn't being matched by the GHA
`docker/metadata-action@v3` due to the `v` prefix.
`v` prefix is common in many projects though.
```
Warning: v1.2 is not a valid semver. More info: https://semver.org/
```
See: https://github.com/docker/metadata-action#typesemver

I don't think a `vM` tag is useful so removed it.
This GHA only runs on tag or master branch push so generating a PR tag is unnecessary. Removed.

GHA log for `v1.2` tag push: https://github.com/salesforce/sloop/actions/runs/3651605823/jobs/6169012887
    @karlskewes
    karlskewes committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    f38697c View commit details
    Browse the repository at this point in the history