fix(ci): Correctly match and tag containers

[karlskewes]

Release tags have been vM.m which wasn't being matched by the GHA docker/metadata-action@v3 due to the v prefix.
v prefix is common in many projects though.

Warning: v1.2 is not a valid semver. More info: https://semver.org/

See: https://github.com/docker/metadata-action#typesemver

I don't think a vM tag is useful so removed it.
This GHA only runs on tag or master branch push so generating a PR tag is unnecessary. Removed.

GHA log for v1.2 tag push: https://github.com/salesforce/sloop/actions/runs/3651605823/jobs/6169012887

Closes #164

Part of #245 "On git tag creation"

[karlskewes]

Push event payload (testing git tag vM.m):

$ cat event.json 
{
  "ref": "refs/tags/v1.3"
}

Run act local testing (on fork, hence GHCR repository):

$ act -j publish --eventpath event.json -s GITHUB_TOKEN="$GITHUB_TOKEN"
<snip>

[Publish/publish]   ❓  ::group::JSON output
| {
|   "tags": [
|     "ghcr.io/karlskewes/sloop:v1.3",
|     "ghcr.io/karlskewes/sloop:sha-f38697c",
|     "ghcr.io/karlskewes/sloop:latest"
|   ],
|   "labels": {
|     "org.opencontainers.image.title": "sloop",
|     "org.opencontainers.image.description": "Kubernetes History Visualization",
|     "org.opencontainers.image.url": "https://github.com/karlskewes/sloop",
|     "org.opencontainers.image.source": "https://github.com/karlskewes/sloop",
|     "org.opencontainers.image.version": "v1.3",
|     "org.opencontainers.image.created": "2023-01-30T09:27:27.619Z",
|     "org.opencontainers.image.revision": "f38697cfc8b33851a166b69624038fc8ddb03e01",
|     "org.opencontainers.image.licenses": "BSD-3-Clause"
|   }
| }

[sana-jawad]

Can we please fix annotation checks too?

[karlskewes]

Sorry which ones?

Unchanged files with check annotations

These? If so I think separate PR using go 1.16+ stdlib..

[sana-jawad]

I see some files under the heading "Unchanged files with check annotations".

[karlskewes]

Righto, yes those are unrelated to this PR and started showing as warnings (not CI failure) when we added go vet checker.
See:

sloop/.github/workflows/test.yml

Lines 35 to 38 in 1ac931c

	- name: Run go vet
	# TODO: Enforce when possible.
	run: |
	go vet ./... || true

We chose not to enforce a clean go vet until someone got around to fixing the issues raised.

It would be simplest to fix the warnings but I was thinking it might be possible to drop the Afero dependency for the standard library embed package.
Maybe I do this as a separate PR when have time (probably soon 😅)?

[sana-jawad]

Sounds good. Lets fix them in a separate PR.