Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate /transaction-confirmation endpoint #1973

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Deprecate /transaction-confirmation endpoint #1973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
95fa5e8
Add swap and staking tests to preview endpoint
iamacook Sep 27, 2024
3ebbc07
Add full test coverage for swaps
iamacook Sep 27, 2024
6be590a
Add full test coverage for TWAPs
iamacook Sep 27, 2024
74a6ecd
Add full test coverage for staking
iamacook Sep 30, 2024
6167981
Mark endpoint as deprecated
iamacook Sep 30, 2024
5a102fb
Merge branch 'main' into preview-tests
iamacook Sep 30, 2024
739ab63
Remove unnecessary argument
iamacook Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/config/entities/__tests__/configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ export default (): ReturnType<typeof configuration> => ({
42161: faker.internet.url({ appendSlash: false }),
11155111: faker.internet.url({ appendSlash: false }),
},
explorerBaseUri: faker.internet.url(),
explorerBaseUri: faker.internet.url({ appendSlash: true }),
restrictApps: false,
allowedApps: [],
maxNumberOfParts: faker.number.int(),
Expand Down
6 changes: 6 additions & 0 deletions src/domain/staking/contracts/decoders/kiln-decoder.helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ export class KilnDecoder extends AbiDecoder<typeof KilnAbi> {
super(KilnAbi);
}

// TODO: When confirmation view endpoint is removed, remove this
// and use this.helpers.isDeposit instead
decodeDeposit(
data: `0x${string}`,
): { method: string; parameters: [] } | null {
Expand All @@ -50,6 +52,8 @@ export class KilnDecoder extends AbiDecoder<typeof KilnAbi> {
}
}

// TODO: When confirmation view endpoint is removed, return only
// publicKeys and don't format it like DataDecoded
decodeValidatorsExit(data: `0x${string}`): {
method: string;
parameters: KilnRequestValidatorsExitParameters[];
Expand Down Expand Up @@ -79,6 +83,8 @@ export class KilnDecoder extends AbiDecoder<typeof KilnAbi> {
}
}

// TODO: When confirmation view endpoint is removed, return only
// publicKeys and don't format it like DataDecoded
decodeBatchWithdrawCLFee(data: `0x${string}`): {
method: string;
parameters: KilnBatchWithdrawCLFeeParameters[];
Expand Down
Loading