Deprecate /transaction-confirmation endpoint
#1973
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11106369405Details
💛 - Coveralls |
iamacook
commented
Sep 30, 2024
Comment on lines
21
to
63
| public findDepositTransaction(args: { | ||
| chainId: string; | ||
| to?: `0x${string}`; | ||
| data: `0x${string}`; | ||
| }): Promise<{ to: `0x${string}`; data: `0x${string}` } | null> { | ||
| return this.findNativeStakingTransaction({ | ||
| signature: KilnNativeStakingHelper.VALIDATORS_EXIT_SIGNATURE, | ||
| ...args, | ||
| }); | ||
| value: string; | ||
| }): { to?: `0x${string}`; data: `0x${string}`; value: string } | null { | ||
| const selector = toFunctionSelector( | ||
| KilnNativeStakingHelper.DEPOSIT_SIGNATURE, | ||
| ); | ||
| return this.transactionFinder.findTransaction( | ||
| (transaction) => transaction.data.startsWith(selector), | ||
| args, | ||
| ); | ||
| } | ||
|
|
||
| public async findWithdrawTransaction(args: { | ||
| public findValidatorsExitTransaction(args: { | ||
| chainId: string; | ||
| to?: `0x${string}`; | ||
| data: `0x${string}`; | ||
| }): Promise<{ to: `0x${string}`; data: `0x${string}` } | null> { | ||
| return this.findNativeStakingTransaction({ | ||
| signature: KilnNativeStakingHelper.WITHDRAW_SIGNATURE, | ||
| ...args, | ||
| }); | ||
| value: string; | ||
| }): { to?: `0x${string}`; data: `0x${string}`; value: string } | null { | ||
| const selector = toFunctionSelector( | ||
| KilnNativeStakingHelper.VALIDATORS_EXIT_SIGNATURE, | ||
| ); | ||
| return this.transactionFinder.findTransaction( | ||
| (transaction) => transaction.data.startsWith(selector), | ||
| args, | ||
| ); | ||
| } | ||
|
|
||
| private async findNativeStakingTransaction(args: { | ||
| signature: string; | ||
| public findWithdrawTransaction(args: { | ||
| chainId: string; | ||
| to?: `0x${string}`; | ||
| data: `0x${string}`; | ||
| }): Promise<{ to: `0x${string}`; data: `0x${string}` } | null> { | ||
| const transaction = this.transactionFinder.findTransaction( | ||
| (transaction) => | ||
| transaction.data.startsWith(toFunctionSelector(args.signature)), | ||
| value: string; | ||
| }): { to?: `0x${string}`; data: `0x${string}`; value: string } | null { | ||
| const selector = toFunctionSelector( | ||
| KilnNativeStakingHelper.WITHDRAW_SIGNATURE, | ||
| ); | ||
| return this.transactionFinder.findTransaction( | ||
| (transaction) => transaction.data.startsWith(selector), | ||
| args, | ||
| ); |
There was a problem hiding this comment.
When writing the tests, I realised we also check the deployment when mapping and fallback to a "standard" transaction there. This is therefore unnecessary, and now covered by tests.
iamacook
commented
Sep 30, 2024
| args.dataDecoded, | ||
| ); | ||
| const publicKeys = this.kilnNativeStakingHelper.splitPublicKeys( | ||
| this.kilnDecoder.decodeValidatorsExit(args.data)!.parameters[0].value, |
There was a problem hiding this comment.
There is a TODO added to the KilnDecoder to simplify this after deprecating the /transaction-confirmations endpoint.
iamacook
commented
Sep 30, 2024
| return []; | ||
| }): Promise<Array<`0x${string}`> | null> { | ||
| if (!args.txHash) { | ||
| return null; |
There was a problem hiding this comment.
I have looked through the client codebase and this will not affect the current implementation. The validators are only mapped on exit transactions, when we know the values.
iamacook
changed the title
/transaction-confirmation endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1927
Currently, the
/transaction-confirmationreturns aTransactionInfo-like entity for the client to render details about swaps and TWAPs. We equally have the/previewendpoint that returns aTransactionInfoentity.This adds swap and staking test coverage to the
/previewendpoint to ensure usage of it can replace the/transaction-confirmationone (migrated from the latter's suite), fixing any found issues.Changes
dataDecoded(because of batches)./previewendpoint./previewendpoint.