Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new design for subcategories page #2233

Merged
merged 6 commits into from
Jan 10, 2024

Conversation

Mohsin-mw
Copy link
Contributor

Fixes Issue

Closes #2178

Changes proposed

I have diligently worked on addressing the issue mentioned above. The following changes have been proposed in my pull request:

Description: Modified the old Card component.

Screenshots

image
image

Note to reviewers

Copy link

vercel bot commented Jan 10, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel.

@rupali-codes first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Mohsin-mw, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@rupali-codes rupali-codes linked an issue Jan 10, 2024 that may be closed by this pull request
Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 9:58am

@Mohsin-mw Mohsin-mw changed the title Dev feat: add new design for subcategories page Jan 10, 2024
@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes
I don't see any major responsive issues here other than sidebar blocking the way and the tooltip description in center.

I think it's okay to merge.

@rupali-codes rupali-codes merged commit d66c953 into rupali-codes:dev Jan 10, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add new design for subcategories page
3 participants