Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new design for subcategories page #2178

Closed
Anmol-Baranwal opened this issue Nov 1, 2023 · 12 comments · Fixed by #2233
Closed

feat: add new design for subcategories page #2178

Anmol-Baranwal opened this issue Nov 1, 2023 · 12 comments · Fixed by #2233
Assignees
@Mohsin-mw
Labels
development Still being developed goal: new-design Design related issues 🚀 ready

Comments

@Anmol-Baranwal
Copy link
Collaborator

Anmol-Baranwal commented Nov 1, 2023 •
edited by rupali-codes
Loading

You can view the figma file here.

image

The design should be responsive.

ℹ️ We recommend updating the styling of existing components, otherwise you can add extra components if there is a need.

  • You also need to implement breadcrumbs based on the current category and subcategory we are currently on.

image

Any changes to the above design are welcome. Please feel free to share your thoughts, and we will discuss them thoroughly.

⚠️ Make sure to push all the changes into dev branch
@Anmol-Baranwal Anmol-Baranwal mentioned this issue Nov 1, 2023
Closed
11 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

To reduce notifications, issues are locked. Your issue will be unlocked when we add the label, 🚀 ready.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
@Anmol-Baranwal Anmol-Baranwal changed the title Subcategory Page feat: add new design for subcategories page Nov 1, 2023
@rupali-codes rupali-codes added goal: new-design Design related issues development Still being developed up for grabs this issue open for the taking 🚀 ready and removed 🔒 locked labels Nov 2, 2023
Repository owner unlocked this conversation Nov 2, 2023
@rupali-codes rupali-codes self-assigned this Nov 3, 2023
@rupali-codes rupali-codes removed the up for grabs this issue open for the taking label Nov 3, 2023
@rupali-codes rupali-codes removed their assignment Nov 5, 2023
@rupali-codes rupali-codes added the up for grabs this issue open for the taking label Nov 5, 2023
@Raj100679
Copy link
Contributor

@rupali-codes Can you assign this issue to me?

@Anmol-Baranwal
Copy link
Collaborator Author

@Raj100679
I have assigned you the issue. Please proceed with it, and don't hesitate to tag any of the maintainers if you require any assistance.

Also, remember to switch to dev mode. It will be easier for development.

Top right corner in figma file
image

@Anmol-Baranwal Anmol-Baranwal removed the up for grabs this issue open for the taking label Nov 8, 2023
@rupali-codes
Copy link
Owner

@Raj100679 any updates? Are you still willing to work on this?

@Raj100679
Copy link
Contributor

Sorry , I totally forgot about it,You can unassign me , I am stuck in end semester exams.

@Anmol-Baranwal Anmol-Baranwal linked a pull request Nov 26, 2023 that will close this issue
Feat: add new design for categories page #2195
Merged
@Anmol-Baranwal Anmol-Baranwal removed a link to a pull request Nov 26, 2023
Feat: add new design for categories page #2195
Merged
@Anmol-Baranwal Anmol-Baranwal added the up for grabs this issue open for the taking label Dec 1, 2023
@Mohsin-mw
Copy link
Contributor

Assistance Needed - "feat: add new design for subcategories page" Issue

Hi Ammol,

I saw the Figma designs for "feat: add new design for subcategories page." Exciting stuff! I'm ready to implement these changes.
Thanks,
MWW

@Anmol-Baranwal Anmol-Baranwal removed the up for grabs this issue open for the taking label Dec 2, 2023
@Anmol-Baranwal
Copy link
Collaborator Author

@Mohsin-mw
I have assigned you the issue. Please proceed with it, and don't hesitate to tag any of the maintainers if you require any assistance.

@rupali-codes
Copy link
Owner

@Raj100679 are you still working on it?

@Raj100679
Copy link
Contributor

@rupali-codes Mohsin is working on it , i am busy with some other work, If i get free I will pick different issue

@rupali-codes
Copy link
Owner

@Mohsin-mw are you working on this issue?

@Mohsin-mw
Copy link
Contributor

Mohsin-mw commented Dec 13, 2023 •
edited
Loading

@Mohsin-mw are you working on this issue?

@rupali-codes yup, i'll make the pull request tomorrow

@rupali-codes
Copy link
Owner

@Mohsin-mw are you working on this issue?

@rupali-codes yup, i'll make the pull request tomorrow

@Mohsin-mw you working on it?

@Mohsin-mw Mohsin-mw mentioned this issue Jan 10, 2024
Merged
@rupali-codes rupali-codes linked a pull request Jan 10, 2024 that will close this issue
feat: add new design for subcategories page #2233
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mohsin-mw Mohsin-mw

Labels
development Still being developed goal: new-design Design related issues 🚀 ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add new design for subcategories page Mohsin-mw/LinksHub
4 participants
@Anmol-Baranwal @rupali-codes @Raj100679 @Mohsin-mw