Feat: add new design for categories page #2195

gakshita · 2023-11-25T18:44:58Z

Changes proposed

New design for category page implemented

* feat: Add Swift Sub Category * Fix small correction * Update database/languages/swift.json Co-authored-by: Christine Belzie <[email protected]> --------- Co-authored-by: Christine Belzie <[email protected]>

* [ADDED]: BlockChain Category * Changes done * Update index.ts * Update index.ts * Changes made * Update CategoryDescriptions.ts

* feat: add iconsax icon * chore: update description Co-authored-by: Rupali Haldiya <[email protected]> --------- Co-authored-by: Anmol Baranwal <[email protected]> Co-authored-by: Rupali Haldiya <[email protected]>

* Added 2 new podcasts * Added Overpowered.AI podcast * Added new link to podcasts * fix: json structure * chore: update description Co-authored-by: Christine Belzie <[email protected]> * chore: remove whitespace Co-authored-by: Aftab Rehan <[email protected]> --------- Co-authored-by: Anmol Baranwal <[email protected]> Co-authored-by: Christine Belzie <[email protected]> Co-authored-by: Aftab Rehan <[email protected]>

* UI libraries in fronted added * added description for the UI libraries * description update for materailui , antdesign, chakraui * removed os tutorials

* Added new course * Added new document

vercel · 2023-11-25T18:45:01Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
linkshub	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 13, 2024 9:03am

github-actions

Thank you, gakshita, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

CBID2

The page looks good @gakshita, but can you revert the commits that don't pertain to the issue that your PR solves?

gakshita · 2023-11-27T14:10:35Z

The page looks good @gakshita, but can you revert the commits that don't pertain to the issue that your PR solves?

Have removed the unecessary commits

aftabrehan

Excellent PR, @gakshita 💪 🚀 💯

Thanks for the contribution. It just needs minor adjustments and then we're good to go.

However, I have only reviewed the code yet. I'll proceed with UI testing and provide my feedback in a while. Feel free to ask if you have any questions or want clarification on something.

assets/icons/AddIcon.tsx

pages/[category]/index.tsx

components/Breadcrumps/index.tsx

aftabrehan · 2023-11-27T14:50:21Z

Could you please align this section to the top?

Could you please make this element clickable (button/link), and redirect users to https://github.com/rupali-codes/LinksHub/issues/new/choose. We'll edit this link in the future. BTW, I think a component for this is already created. Here it's used.

The titles look too bold. Can you please make it thin?

Oops, it's not ready for the light mode. We have a light design mode available in Figma.

I guess it's not responsive, is it?

No need to stress! If you ever need assistance, feel free to reach out. We're here to support and help you on your learning journey. 🚀

gakshita · 2023-11-29T18:20:16Z

@aftabrehan @rupali-codes @CBID2 all changes have been fixed from my side!

aftabrehan

Thanks @gakshita! The code looks much better now.

However, here are a few suggestions from my side.

pages/[category]/index.tsx

tailwind.config.js

aftabrehan · 2023-11-30T13:17:17Z

It all looks super awesome 🙌. Great work @gakshita. Please, help to adjust these two things as well, and then we're good to merge this PR.

Can you please add the background on the parent element?

Can you please use a full width for the tile on the mobile screen to cover extra space?

Anmol-Baranwal · 2023-12-01T17:26:50Z

@gakshita
Are you facing any problems regarding the changes? Please let me know; I will gladly help you.

gakshita · 2023-12-03T12:20:14Z

Couldn't find item description data i the object, rest changes have been pushed.

aftabrehan · 2023-12-03T14:41:25Z

Couldn't find item description data i the object, rest changes have been pushed.

@gakshita, Please, check this for reference.

LinksHub/components/TopBar/TopBar.tsx

Lines 17 to 28 in eba4b81

    
           const category = router.asPath 
        
           const categoryName = category.split('/')[1].split('-').join(' ') 
        
           const subcategoryName = category?.split('/')[2]?.split('-').join(' ') 
        
           const searchQuery = router.query.query?.toString() || '' 
        
           let cleanedCategory = '' 
        
           cleanedCategory = (subcategoryName || categoryName) 
        
             .replaceAll(regEx, ' ') 
        
             .replaceAll('search query ', '') 
        
           const description = categoryDescriptions[searchQuery || subcategoryName] || '' 
        
           const isResourceSelected = isValidResource(searchQuery || subcategoryName)

CBID2 · 2023-12-17T17:33:52Z

Any updates @gakshita? 😁

rupali-codes · 2024-01-10T08:22:55Z

@gakshita you still working on it?

vercel · 2024-01-13T09:00:14Z

Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel.

@rupali-codes first needs to authorize it.

rupali-codes and others added 13 commits November 2, 2023 23:20

chore: remove hacktoberfest checkmark

1e6a81b

feat: adding Aftab to Codeowners file (rupali-codes#2167)

a7d5079

chore: Add Swift Sub Category (rupali-codes#2160)

6a200b2

* feat: Add Swift Sub Category * Fix small correction * Update database/languages/swift.json Co-authored-by: Christine Belzie <[email protected]> --------- Co-authored-by: Christine Belzie <[email protected]>

[ADDED]: BlockChain Category (rupali-codes#2044)

c6e97bf

* [ADDED]: BlockChain Category * Changes done * Update index.ts * Update index.ts * Changes made * Update CategoryDescriptions.ts

chore: Added a new Ui library Url (rupali-codes#2159)

143af2f

chore: Add Easings in animations subcategory (rupali-codes#2179)

1d41969

chore: add iconsax icon (rupali-codes#2121)

f8b9f41

* feat: add iconsax icon * chore: update description Co-authored-by: Rupali Haldiya <[email protected]> --------- Co-authored-by: Anmol Baranwal <[email protected]> Co-authored-by: Rupali Haldiya <[email protected]>

Update SideNavbar.tsx (rupali-codes#2116)

3c42aab

chore: added new resources to ui-libraries (rupali-codes#2180)

cf58535

* UI libraries in fronted added * added description for the UI libraries * description update for materailui , antdesign, chakraui * removed os tutorials

Added official documents for Go programming language (rupali-codes#2154)

e69d910

* Added new course * Added new document

Feat : Category web design

bfd74c0

Fix : Synced with dev branch

718f32a

gakshita requested review from rupali-codes, CBID2 and Anmol-Baranwal as code owners November 25, 2023 18:44

github-actions bot assigned gakshita Nov 25, 2023

github-actions bot reviewed Nov 25, 2023

View reviewed changes

vercel bot deployed to Preview November 25, 2023 18:46 View deployment

Merge branch 'dev' into main

31ea1f5

vercel bot deployed to Preview November 25, 2023 18:49 View deployment

CBID2 reviewed Nov 25, 2023

View reviewed changes

Anmol-Baranwal linked an issue Nov 26, 2023 that may be closed by this pull request

feat: add new design for subcategories page #2178

Closed

Anmol-Baranwal removed a link to an issue Nov 26, 2023

feat: add new design for subcategories page #2178

Closed

Anmol-Baranwal linked an issue Nov 26, 2023 that may be closed by this pull request

feat: add new design for categories page #2177

Closed

Fix : Removed unnecessary commits

4358ad3

gakshita requested a review from aftabrehan as a code owner November 27, 2023 14:07

vercel bot deployed to Preview November 27, 2023 14:08 View deployment

aftabrehan requested changes Nov 27, 2023

View reviewed changes

gakshita added 4 commits November 28, 2023 12:47

Fix : Formatting fixed

94ad233

Fix : SVGs fixed

b67e340

Fix : Respomsiveness fixed

8e7d120

Fix : CSS fixed

a1b2533

vercel bot deployed to Preview November 28, 2023 07:53 View deployment

Fix : CSS fixed

e192be2

vercel bot deployed to Preview November 28, 2023 07:57 View deployment

Fix : Light theme fixed

ece7ee5

vercel bot deployed to Preview November 29, 2023 18:18 View deployment

aftabrehan reviewed Nov 30, 2023

View reviewed changes

pages/[category]/index.tsx Outdated Show resolved Hide resolved

tailwind.config.js Outdated Show resolved Hide resolved

Fix : Minor css

2aa239c

vercel bot deployed to Preview December 3, 2023 12:20 View deployment

CBID2 added goal: new-design Design related issues priority: high Making completely new feature labels Dec 22, 2023

rupali-codes added 2 commits January 12, 2024 16:30

Merge branch 'dev' of github.com:rupali-codes/LinksHub into gakshita_dev

67de99e

fix: category description issue

32f5c5b

vercel bot deployed to Preview January 13, 2024 09:03 View deployment

rupali-codes merged commit aac8277 into rupali-codes:dev Jan 13, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: add new design for categories page #2195

Feat: add new design for categories page #2195

gakshita commented Nov 25, 2023 •

edited by Anmol-Baranwal

Loading

vercel bot commented Nov 25, 2023 •

edited

Loading

github-actions bot left a comment

CBID2 left a comment

gakshita commented Nov 27, 2023

aftabrehan left a comment

aftabrehan commented Nov 27, 2023

gakshita commented Nov 29, 2023

aftabrehan left a comment

aftabrehan commented Nov 30, 2023

Anmol-Baranwal commented Dec 1, 2023

gakshita commented Dec 3, 2023

aftabrehan commented Dec 3, 2023

CBID2 commented Dec 17, 2023

rupali-codes commented Jan 10, 2024

vercel bot commented Jan 13, 2024

Feat: add new design for categories page #2195

Feat: add new design for categories page #2195

Conversation

gakshita commented Nov 25, 2023 • edited by Anmol-Baranwal Loading

Changes proposed

vercel bot commented Nov 25, 2023 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

CBID2 left a comment

Choose a reason for hiding this comment

gakshita commented Nov 27, 2023

aftabrehan left a comment

Choose a reason for hiding this comment

aftabrehan commented Nov 27, 2023

gakshita commented Nov 29, 2023

aftabrehan left a comment

Choose a reason for hiding this comment

aftabrehan commented Nov 30, 2023

Anmol-Baranwal commented Dec 1, 2023

gakshita commented Dec 3, 2023

aftabrehan commented Dec 3, 2023

CBID2 commented Dec 17, 2023

rupali-codes commented Jan 10, 2024

vercel bot commented Jan 13, 2024

gakshita commented Nov 25, 2023 •

edited by Anmol-Baranwal

Loading

vercel bot commented Nov 25, 2023 •

edited

Loading