Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a test case for cft options not supported #217

Open
wants to merge 3 commits into
base: rolling
Choose a base branch
from

Conversation

iuhilnehc-ynos
Copy link
Contributor

@iuhilnehc-ynos iuhilnehc-ynos commented Feb 27, 2023

To cooperate with updating the ros2/rmw_fastrtps#672 and ros2/rmw_connextdds#106, I need to add a test here.

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having failure case makes sense, to check rmw can create subscription even with cft failure.

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, other than a suggestion.

test_rmw_implementation/test/test_subscription.cpp Outdated Show resolved Hide resolved
@iuhilnehc-ynos
Copy link
Contributor Author

iuhilnehc-ynos commented Sep 5, 2023

repos

CI for #217, ros2/rmw_fastrtps#672, ros2/rmw_connextdds#106
(Based on ros2/rcl_content_filter_fallback#1, ros2/rcl#996, ros2/demos#579)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status
12:59:52 <== '. ../venv/bin/activate && /home/jenkins-agent/workspace/ci_linux/venv/bin/colcon mixin update default' exited with return code '1'
12:59:53 Build step 'Execute shell' marked build as failure
12:59:53 $ ssh-agent -k
12:59:53 unset SSH_AUTH_SOCK;
12:59:53 unset SSH_AGENT_PID;
12:59:53 echo Agent pid 2418626 killed;
12:59:53 [ssh-agent] Stopped.
12:59:53 [CMakeGNU C Compiler (gcc)Clang (LLVM based)Clang-Tidy] Skipping execution of recorder since overall result is 'FAILURE'
12:59:53 [Cobertura] Publishing Cobertura coverage report...

(It seems there is an issue in CI.)

@iuhilnehc-ynos
Copy link
Contributor Author

iuhilnehc-ynos commented Sep 5, 2023

repos
Try again and CI for #217, ros2/rmw_fastrtps#672, ros2/rmw_connextdds#106.

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants