zenoh: Shutdown the node properly in component tests #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
|
Why this change? The context is initialized in the |
fujitatomoya
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
lgtm. the fix itself makes sense to me that we call shutdown explicitly once it completes the all test cases with this fixture.
i would also like to know @alsora 's comment above. i think default_context will be destructed when the process space is destroyed, then context will be shutdown. What kind of problem did you have with rmw_zenoh?
|
@ahcorde any chance you opened this PR because you ran into the If so I wonder if my comment here explains why we need this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.