Skip rmw zenoh content filtering tests #2627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
fujitatomoya
approved these changes
Sep 12, 2024
Is the segfault on the rmw_zenoh side or here? Either way we should ensure we don't segfault anywhere and instead throw appropriate errors? 🤔 |
|
@ahcorde do we still need this PR given the fix from ros2/rmw_zenoh#282? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content filtering is still not implemented in
rmw_zenohhttps://github.com/ros2/rmw_zenoh/blob/60b72f07a7d7254aeed8c39c11174bb52806ee62/rmw_zenoh_cpp/src/rmw_zenoh.cpp#L1690-L1713
These tests generates a segfault, I think we can skip them for now.