Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement instance cloning methods in WeakDom #312

Merged
merged 25 commits into from
Jul 7, 2023
Merged

Implement instance cloning methods in WeakDom #312

merged 25 commits into from
Jul 7, 2023

Commits on Jul 5, 2023

  1. Preliminary implementation of clone_within and clone_external

    @kennethloeffler
    kennethloeffler committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    b7e5c26 View commit details
    Browse the repository at this point in the history

  2. Rename CloneContext.dom -> CloneContext.source

    @kennethloeffler
    kennethloeffler committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    bdbaeb2 View commit details
    Browse the repository at this point in the history

  3. Add tests

    @kennethloeffler
    kennethloeffler committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    378ff0d View commit details
    Browse the repository at this point in the history

  4. Rename clone_external -> clone_into_external

    @kennethloeffler
    kennethloeffler committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    74bedb5 View commit details
    Browse the repository at this point in the history

  5. Add snapshots 

    Looking good!
    @kennethloeffler
    kennethloeffler committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    7352f7b View commit details
    Browse the repository at this point in the history

  6. Refactor: CloneContext is now POD, move implementations into WeakDom 

    No longer have to take &mut self for clone_into_external
    @kennethloeffler
    kennethloeffler committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    d0ee591 View commit details
    Browse the repository at this point in the history

  7. Add a little docs

    @kennethloeffler
    kennethloeffler committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    1643fd5 View commit details
    Browse the repository at this point in the history

  8. Rename instancebuilder_from_ref -> ref_into_instancebuilder

    @kennethloeffler
    kennethloeffler committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    6fdb764 View commit details
    Browse the repository at this point in the history

  9. Refactor: ref_into_instancebuilder simplification

    @kennethloeffler
    kennethloeffler committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    b888d10 View commit details
    Browse the repository at this point in the history

  10. Rename old_ref -> original_ref

    @kennethloeffler
    kennethloeffler committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c6c90a6 View commit details
    Browse the repository at this point in the history

  11. Consume CloneContext in rewrite_refs

    @kennethloeffler
    kennethloeffler committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    046ebc0 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. ref_into_instancebuiler->clone_ref_as_builder, add a little docs

    @kennethloeffler
    kennethloeffler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    7b94456 View commit details
    Browse the repository at this point in the history

  2. Refactor: WeakDom::rewrite_refs -> CloneContext::rewrite_refs 

    CloneContext is still sorta POD...
    @kennethloeffler
    kennethloeffler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    5e32765 View commit details
    Browse the repository at this point in the history

  3. Move CloneContext down below WeakDom

    @kennethloeffler
    kennethloeffler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    fc26bdc View commit details
    Browse the repository at this point in the history

  4. Refactor: move WeakDom::clone_ref_as_builder into CloneContext 

    CloneContext definitely ain't no POD anymore

It was nice while it lasted...
    @kennethloeffler
    kennethloeffler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    85f49a8 View commit details
    Browse the repository at this point in the history

  5. Clarify the docs

    @kennethloeffler
    kennethloeffler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    0c6a90e View commit details
    Browse the repository at this point in the history

  6. Docs docs docs

    @kennethloeffler
    kennethloeffler committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    1ba6eab View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Set ref properties to none if they DNE in the destination WeakDom

    @kennethloeffler
    kennethloeffler committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    a253fef View commit details
    Browse the repository at this point in the history

  2. Edit clone_into_external test to show refs that DNE are set to none

    @kennethloeffler
    kennethloeffler committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    7a88c91 View commit details
    Browse the repository at this point in the history

  3. Put (valid) ref pointing outside the subtree in clone_within test 

    Currently fails because the rewrite_refs implementation in
a253fef rewrites all refs that point
outside the cloned subtree to none, which is not correct

Revert "Fix ref rewrites"

This reverts commit 41a2fe6f1418a48e86d622a336854f9276977c38.
    @kennethloeffler
    kennethloeffler committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    040df5e View commit details
    Browse the repository at this point in the history

  4. Correctly rewrite refs that point outside subtree in rewrite_refs

    @kennethloeffler
    kennethloeffler committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    aafe32c View commit details
    Browse the repository at this point in the history

  5. Don't need this type annotation

    @kennethloeffler
    kennethloeffler committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    e16aeaa View commit details
    Browse the repository at this point in the history

  6. Mention the out-of-subtree ref case in clone_into_external docs 

    Co-authored-by: Micah <[email protected]>
    @kennethloeffler @Dekkonot
    kennethloeffler and Dekkonot committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    e2bab9a View commit details
    Browse the repository at this point in the history

  7. Add changelog entry

    @kennethloeffler
    kennethloeffler committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    2da1e4b View commit details
    Browse the repository at this point in the history

  8. Fix typo in rewrite_refs comment

    @kennethloeffler
    kennethloeffler committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    797954b View commit details
    Browse the repository at this point in the history