Implement instance cloning methods in WeakDom #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking good!
No longer have to take &mut self for clone_into_external
kennethloeffler
commented
Jul 6, 2023
rbx_dom_weak/src/dom.rs
Outdated
| } | ||
|
|
||
| ctx.ref_rewrites.insert(original_ref, new_ref); | ||
| builder |
There was a problem hiding this comment.
This builder never has any children and kinda makes me want a fast path in WeakDom::insert that doesn't create a VecDeque for builders with no children - kind of irrelevant for this PR, but I'll put it on my back burner...
CloneContext is still sorta POD...
CloneContext definitely ain't no POD anymore It was nice while it lasted...
Dekkonot
reviewed
Jul 7, 2023
Currently fails because the rewrite_refs implementation in a253fef rewrites all refs that point outside the cloned subtree to none, which is not correct Revert "Fix ref rewrites" This reverts commit 41a2fe6f1418a48e86d622a336854f9276977c38.
Dekkonot
reviewed
Jul 7, 2023
|
Can you add these to the Changelog also? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #282 by implementing
WeakDom::clone_withinandWeakDom::clone_into_external.