Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replication dropdown max height + minor css #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

debjyoti-pandit
Copy link
Contributor

@debjyoti-pandit debjyoti-pandit commented Aug 10, 2022

fixes: https://issues.redhat.com/browse/DFMS-209
along with the replication dropdown raised by the QA team.

before
image
image
(no padding as u can see)
image
image
image
image


after
image
image
image
image
image
image

@debjyoti-pandit
Copy link
Contributor Author

/assign @SanjalKatiyar

@SanjalKatiyar
Copy link
Collaborator

@debjyoti-pandit please add before/after screenshots.

@debjyoti-pandit
Copy link
Contributor Author

@debjyoti-pandit please add before/after screenshots.

Done @SanjalKatiyar

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: debjyoti-pandit
Once this PR has been reviewed and has the lgtm label, please ask for approval from sanjalkatiyar by writing /assign @sanjalkatiyar in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SanjalKatiyar
Copy link
Collaborator

/test mcg-ms-console-e2e-aws

@debjyoti-pandit
Copy link
Contributor Author

/test mcg-ms-console-e2e-aws

@debjyoti-pandit
Copy link
Contributor Author

/test mcg-ms-console-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2022

@debjyoti-pandit: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/mcg-ms-console-e2e-aws 6cc1516 link true /test mcg-ms-console-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants