fix: replication dropdown max height + minor css

red-hat-storage · Aug 10, 2022 · 5f004c4 · 5f004c4
1 parent 51048e4
commit 5f004c4
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 5 deletions.
diff --git a/locales/en/plugin__mcg-ms-console.json b/locales/en/plugin__mcg-ms-console.json
@@ -193,8 +193,8 @@
   "Edit annotations": "Edit annotations",
   "Delete {{resourceLabel}}": "Delete {{resourceLabel}}",
   "Resource Page": "Resource Page",
-  "Filter policy by name": "Filter policy by name",
-  "Filter policy by label": "Filter policy by label",
+  "Filter by name": "Filter by name",
+  "Filter by label": "Filter by label",
   "Create resource": "Create resource",
   "Delete {{kind}}?": "Delete {{kind}}?",
   "Are you sure you want to delete <2>{{resourceName}}</2> in namespace <6>{{namespace}}</6>?": "Are you sure you want to delete <2>{{resourceName}}</2> in namespace <6>{{namespace}}</6>?",

diff --git a/packages/components/bucket-policy/bucket-policy.scss b/packages/components/bucket-policy/bucket-policy.scss
@@ -3,7 +3,7 @@
     margin: var(--pf-global--spacer--lg) var(--pf-global--spacer--lg) 0
       var(--pf-global--spacer--lg);
     max-width: 75%;
-    padding-bottom: 20vh;
+    padding-bottom: 30vh;
   }
 
   &__form--margin-bottom {
@@ -45,3 +45,8 @@
 .mcgms-breadcrumbs-header {
   margin-top: var(--pf-global--spacer--md);
 }
+
+.pf-c-select__menu {
+  max-height: 30vh;
+  overflow-y: auto;
+}
diff --git a/packages/components/data-resource/data-resource.scss b/packages/components/data-resource/data-resource.scss
@@ -3,6 +3,7 @@
 }
 
 .nb-endpoints-form-entry {
+  padding-right: var(--pf-global--spacer--xl);
   width: 100%;
 }
 
@@ -71,6 +72,10 @@
   overflow-y: auto;
 }
 
+.mcgms-resourceDropdown__container {
+  padding-right: var(--pf-global--spacer--xl);
+}
+
 .mcgms-disabledDropdown__container {
   min-width: 20em;
 }

diff --git a/packages/utils/list-page/list-page.tsx b/packages/utils/list-page/list-page.tsx
@@ -88,8 +88,8 @@ export const GenericListPage: React.FC<GenericListPageProps> = ({
             loaded={loaded}
             onFilterChange={onFilterChange}
             hideColumnManagement={true}
-            nameFilterPlaceholder={t('Filter policy by name')}
-            labelFilterPlaceholder={t('Filter policy by label')}
+            nameFilterPlaceholder={t('Filter by name')}
+            labelFilterPlaceholder={t('Filter by label')}
           />
         </div>
         <div className="create-resource__button">