Issue #228: Fix authorization in gRPC Calls #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 41.82% 42.07% +0.24%
==========================================
Files 98 99 +1
Lines 4368 4409 +41
==========================================
+ Hits 1827 1855 +28
- Misses 2385 2398 +13
Partials 156 156
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sunnyagg
reviewed
Aug 17, 2021
sunnyagg
reviewed
Aug 18, 2021
sunnyagg
reviewed
Aug 18, 2021
sunnyagg
approved these changes
Aug 18, 2021
shivasishdas
suggested changes
Aug 19, 2021
--Wrote a custom auth interceptor which calls custom AuthFuncOverride with request body --Custom version of AuthFuncOverride accepting request body --Modified implementations of AuthFuncOverride in admin, publisher and subscriber server to accept request body --New file: metro/service/web/server.go having the implementation of fetching the project id from request payload --Fetch project-id from request payload using resources' name and extracted using regex capturing group
--Reverted code commented during testing
--Fixed breaking UTs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnaryServerAuthInterceptorandserviceAuthFuncOverrideinterface which declares theAuthFuncOverridefunction. If the server (read controller) implements the interface function, the override function is called with the request body and the full function name.grpc_auth.UnaryServerInterceptor, except that the override function gets the request body.