Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Authorization in GRPC #228

Closed
razorao opened this issue Aug 17, 2021 · 0 comments · Fixed by #229
Closed

Fix Authorization in GRPC #228

razorao opened this issue Aug 17, 2021 · 0 comments · Fixed by #229
Assignees
@razorao

Comments

@razorao
Copy link
Contributor

razorao commented Aug 17, 2021

Currently, project id is fetched from the URI and is validated against users's project id to perform authorization. However, in case of GRPC, the URI does not exist leading to breakage of authorization.
@razorao razorao self-assigned this Aug 17, 2021
razorao added a commit that referenced this issue Aug 17, 2021
@razorao
Issue #228: Fix authorization in GRPC calls
55850ee 
	--Wrote a custom auth interceptor which calls custom AuthFuncOverride with request body
	--Custom version of AuthFuncOverride accepting request body
	--Modified implementations of AuthFuncOverride in admin, publisher and subscriber server to accept request body
	--New file: metro/service/web/server.go having the implementation of fetching the project id from request payload
	--Fetch project-id from request payload using resources' name and extracted using regex capturing group
razorao added a commit that referenced this issue Aug 17, 2021
@razorao
Issue #228: Fix authorization in GRPC calls
710f92e 
	--Reverted code commented during testing
razorao added a commit that referenced this issue Aug 17, 2021
@razorao
Issue #228: Fix authorization in GRPC calls
32d22f0 
	--Fixed breaking UTs
razorao added a commit that referenced this issue Aug 17, 2021
@razorao
Issue #228: Fix authorization in GRPC calls
0953af3 
	--Wrote a custom auth interceptor which calls custom AuthFuncOverride with request body
	--Custom version of AuthFuncOverride accepting request body
	--Modified implementations of AuthFuncOverride in admin, publisher and subscriber server to accept request body
	--New file: metro/service/web/server.go having the implementation of fetching the project id from request payload
	--Fetch project-id from request payload using resources' name and extracted using regex capturing group
razorao added a commit that referenced this issue Aug 17, 2021
@razorao
Issue #228: Fix authorization in GRPC calls
d81f454 
	--Reverted code commented during testing
razorao added a commit that referenced this issue Aug 17, 2021
@razorao
Issue #228: Fix authorization in GRPC calls
48ab022 
	--Fixed breaking UTs
@shivasishdas shivasishdas linked a pull request Aug 19, 2021 that will close this issue
Issue #228: Fix authorization in gRPC Calls #229
Merged
razorao added a commit that referenced this issue Aug 20, 2021
@razorao
Issue #228: Fix authorization in GRPC calls
f0a2282 
	--Wrote a custom auth interceptor which calls custom AuthFuncOverride with request body
	--Custom version of AuthFuncOverride accepting request body
	--Modified implementations of AuthFuncOverride in admin, publisher and subscriber server to accept request body
	--New file: metro/service/web/server.go having the implementation of fetching the project id from request payload
	--Fetch project-id from request payload using resources' name and extracted using regex capturing group
razorao added a commit that referenced this issue Aug 20, 2021
@razorao
Issue #228: Fix authorization in GRPC calls
e09ef34 
	--Reverted code commented during testing
razorao added a commit that referenced this issue Aug 20, 2021
@razorao
Issue #228: Fix authorization in GRPC calls
8db0df3 
	--Fixed breaking UTs
razorao added a commit that referenced this issue Aug 27, 2021
@razorao
Issue #228: Fix authorization in gRPC Calls (#229)
3bb4708 
* Issue #228: Fix authorization in GRPC calls
	--Wrote a custom auth interceptor which calls custom AuthFuncOverride with request body
	--Custom version of AuthFuncOverride accepting request body
	--Modified implementations of AuthFuncOverride in admin, publisher and subscriber server to accept request body
	--New file: metro/service/web/server.go having the implementation of fetching the project id from request payload
	--Fetch project-id from request payload using resources' name and extracted using regex capturing group

* Issue #228: Fix authorization in GRPC calls
	--Reverted code commented during testing

* Issue #228: Fix authorization in GRPC calls
	--Fixed breaking UTs

* Tidied the dependencies

* Added unit tests

* removed commented code

* Addressed review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@razorao razorao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #228: Fix authorization in gRPC Calls razorpay/metro
1 participant
@razorao