Update adapter json test framework to validate BidVideo #3835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few tests that do not specify `primary_category` and would have failed; we can update the tests or update the structure. Here I update the structure assuming that the tests show the intention.
Code coverage summaryNote:
adapterstestRefer here for heat map coverage report |
openrtb_ext/bid.go
Outdated
Comment on lines
77
to
78
| Duration int `json:"duration,omitempty"` | ||
| PrimaryCategory string `json:"primary_category,omitempty"` |
There was a problem hiding this comment.
Good catch!
I think we need to fix unit tests instead. Here is why:
- We will not hide known issues in unit tests.
- We will not modify core structures to satisfy unit tests.
- We will have unit tests in this PR that will show how to use this new feature and set an examples for future contributors.
I only had to fix 3 files to make unit tests pass:
/adapters/freewheelssp/freewheelssptest/exemplary/multi-imp.json
/adapters/yeahmobi/yeahmobitest/exemplary/simple-video.json
/adapters/pubmatic/pubmatictest/exemplary/video.json
Change in adapter json tests is expected here. I'll confirm this with the team just in case :)
There was a problem hiding this comment.
Thank you, pushed another commit efd1719 to fix adapter tests and remove the change in bid.go
VeronikaSolovei9
approved these changes
Sep 11, 2024
bsardo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapter json test framework appears to ignore the
expectedBid.videoobject and so the related tests do not test anything.Add
expectedBid.Videoand diff function to validate this part of the adapter response. There are a few tests that only havevideo.durationand novideo.primary_categoryand those would fail; we can update the tests or update theExtPrebidVideostructure to make them optional.Here I update the structure assuming that the tests show the intention, but if that's not desirable we could update the tests instead.
There's a similar issue with exchange tests that I will look to address separately.
Fixes the existing adapter tests including the one added in #3834 so they actually do validate the expected response.