Update exchange json tests with correct hb_pb_cat_dur #3836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some exchange json tests define the
bidVideo
response component but do not actually load it, so they validatehb_pb_cat_dur
values that are different from what PBS would generate. The difference is that PBS adds_30s
when that duration is given inBidVideo
, but the tests use_0s
.This change updates
bidderBid
definition sobidVideo
is deserialized into the mock response asBidVideo
.It also updates the json tests with the correct value for
hb_pb_cat_dur
. Alternatively, we could preserve the current values and remove BidVideo from the tests that don't need it.A solution to the same issue in adapter tests was proposed in #3835
I am not sure why
BidVideo
is still necessary though.Bid.Cat[0]
andBid.Dur
are available to be passed back in the Bid response, so the targeting code could use them instead.