Adds the option for non cash-effective dividend payments

[Pnda87]

This commit allows to mark dividends as non cash-effective. It can be used, e.g., for spin-offs or stock dividends, where the paid amount is directly reinvested in a stock and not paid in cash. The marked dividends can be excluded in the payment view to keep a clean view of the dividend development. All non cash-effective dividends can be filtered and listed in the transaction view.

[buchen]

Hi @Pnda87,

thanks for the pull request. I fully understand your motivation. Personally, I think it would be valuable to be able to maintain a securities account without a cash account. That would mean having "non-cash effective" dividend, tax, and fee transactions. If we had those, then one could also build "composite transactions" for stock dividends, etc. And, as a benefit, we actually could map dividend transactions better to the portfolio (today multiple portfolios could have the same reference account).

So far my thinking was to allow a limited set of AccountTransactions also on the Portfolio and adapt the performance calculation accordingly. This includes the dialog to create and edit transactions, the ClientSnaphot and ClientIndex classes with the main calculations, the client filter, etc. As you can guess that is a very big change and the effort is the reason I never got to implementing it.

Your proposal is limited in scope - by introducing the "nonCashEffective" flag on the account transaction. I see two challenges:

• First, logically it is hard for the user to understand that he still needs a cash account even though the transaction is not cash effective. This muddles the UI.
• Second, I believe once we adopt the implementation to honor the new flag, the effort will not be significantly smaller than for the solution outlined above. In the current pull request, the balance does not reflect non cash effective dividends, the (filtered) performance is calculated as if it were cash effective, internal rate of return is not including it, etc.

For these reasons, I am at the moment not inclined to introduce a "non cash effective" flag on the transaction. However, I leave this PR open for the time being to continue our discussion and hear your arguments