Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds option for non cash-effective dividend payments. #2971

Closed
wants to merge 1 commit into from

Conversation

Pnda87
Copy link
Contributor

@Pnda87 Pnda87 commented Sep 4, 2022

Payments marked as such can be excluded in the payments
report to display only cash effective transactions.

issue: #2970

Payments marked as such can be excluded in the payments
report to display only cash effective transactions.
@Nirus2000
Copy link
Member

Hello @Pnda87
would it be possible to add a few more TestCases and the missing translations?

If we look under all transactions and sort by dividends as an example, how are they identified? 🤔

Greetings
Alex

@Pnda87
Copy link
Contributor Author

Pnda87 commented Sep 5, 2022

In my opinion, they dont need to be identifiable under all transactions as the option is not applicable to 99% of all transactions.
If the option is set or not can be seen in the edit dialog of the specific dividend transaction

rg. translations: EN+DE is there, the other languages shall ideally be done by natives.

@Nirus2000
Copy link
Member

Let's say I have 100 divide transactions and have disabled several of them but forgot which ones, that would be very tedious for the user to always call up 100 transactions to see if it has been disabled.

@Pnda87 Pnda87 marked this pull request as draft October 24, 2022 07:14
@Pnda87 Pnda87 marked this pull request as ready for review October 26, 2023 19:14
@Pnda87
Copy link
Contributor Author

Pnda87 commented Oct 26, 2023

I rebased the code on the current master and refined it a bit more. cf. #3610

@Pnda87 Pnda87 closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants