Set PeerHostname/PeerPort rather than URL based on connection. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Jan 8, 2017
| if port, err := strconv.Atoi(portString); err != nil { | ||
| ext.PeerPort.Set(h.sp, uint16(port)) | ||
| } | ||
| } |
There was a problem hiding this comment.
actually, I think both of these are wrong. The url and peer tags should be set for all traced http requests (i.e. in RoundTrip method), not only those for which httptrace.ClientTrace is enabled. What should really happen here is:
h.sp.LogKV(log.String("event", "GetConn"), log.String("hostPort", hostPort))
(or split host/port into two k/v pairs if not lazy).
I don't know how much more overhead httptrace.ClientTrace adds, it would be nice to make it optional. The RoundTrip is really what's needed for the actual tracing/propagation.
There was a problem hiding this comment.
I don't see a way to get the actual peer hostname from the request context, only via the GotConn callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the gokit code:
https://github.com/go-kit/kit/blob/023cbf047fba5be6bcd44e80f2558a8e7554e8ab/tracing/opentracing/http.go#L26
Fixes #2